Tooling for improved local dev experience #1423
Conversation
This will configure and launch a stack. It isn't grabbing some things correctly, because of some more env-specific configuration that needs to be done. However, it's a solid start.
This worked for test. There is now more cleanup. There's a notional split between "setting up to run" and "getting the variables into the container." This moves all the work out of the container. It could, perhaps, all be moved into the container if the correct env was passed for secrets gathering?
|
@jadudm does this work assume you have an account number entered in your kion.yml? If so, what account number do I need in there? If I enter the account number for bluebutton-non-prod, will I still be able to test against SBX? |
|
I get a 400 Invalid username or password. after updating my .kion.yml. I did just change my EUA password, I wonder if that's why. Could also be the github issues. |
|
Getting a 403 error now (Unable to generate short-term access keys for the requested role. Verify the role exists and you have sufficient permissions to access it.), could you point me towards you Confluence page on how you set up your kion.yml specifically? |
jimmyfagan
left a comment
jimmyfagan
left a comment
There was a problem hiding this comment.
A few comments and questions, but overall this seems to work well. Continuing a little testing, but in the meantime want to submit my initial review. Is it accurate that the ENV=test in the PR description should actually be bfd=test?
jimmyfagan
left a comment
jimmyfagan
left a comment
There was a problem hiding this comment.
Just another batch of comments/questions coming out of a bit more testing.
|
|
Oops. Accidentally closed the PR. Reopened. |
jimmyfagan
left a comment
jimmyfagan
left a comment
There was a problem hiding this comment.
A few more minor comments, we can probably work through whatever is left in a huddle sometime today.
jimmyfagan
left a comment
jimmyfagan
left a comment
There was a problem hiding this comment.
Works for me, with and without daemon=1 and also works on restart without having to take everything all the way down to start from scratch. I'll consider this approved, though this is likely the type of review that would warrant at least one more approval to ensure it works for other people too.
| msls: | ||
| image: msls-local:latest | ||
| platform: linux/amd64 | ||
| command: /code/start-local.sh | ||
| ports: | ||
| - "8080:8080" | ||
| volumes: | ||
| - ../msls-local:/code |
There was a problem hiding this comment.
I'm seeing that msls container starts up whether or not auth==mock. Maybe that's harmless enough though, not a blocker for approval, just pointing it out in case you want to consider addressing that.
JIRA Ticket:
BB2-4232
What Does This PR Do?
This PR:
msls-localinto its own, top-level directory, as it is a stand-alone (albeit local-only) applicationbuild-localandrun-localdev-localto support building and running the applicationdev-localThe goal is to be able to do the following:
and be up-and-running with a local dev stack.
What Should Reviewers Watch For?
"On my machine...," I can stand up the stack under various configurations, and (perhaps most importantly), for live tests against
testandsbx, can run all unit tests as well as navigate the test client for v2 and v3.There may be further work with this local stack on the
local/mockconfiguration, and future opportunity around integration of the Selenium tests.If you follow the steps above/in the README in
dev-local, and have a local dev experience that doesn't "just work," or worse, yields an application that is misconfigured or misbehaves in some way, then raise a 🎏 .Validation
Try it. Specifically:
What Security Implications Does This PR Have?
None. This is strictly for local development.
Any Migrations?
No migrations.