Merged
Conversation
Collaborator
|
Ah okay, so I missed one of the temp_dir's that we needed. Thank you for tracking this down! |
wilsonsj100
reviewed
Aug 29, 2025
Collaborator
wilsonsj100
left a comment
There was a problem hiding this comment.
That makes sense regarding the intermediate files. Thank you!
Collaborator
|
I guess we likely need to resubmit as 1.2.1 now that this has been changed - correct? |
Member
Author
|
Hahaha yes don't forget the version number bump! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, the problem documented in #104 was
ffi_qaqc()example runs (#' x <- ffi_qaqc(fd, ...rmarkdown::render()is called within ffi_qaqcThis PR adds
intermediates_dir = output_dirto the render call, which should fix things. I also fixed a syntax problem in theffi_metadata_matchdocumentationCloses #104