Skip to content

Comments

ffi_qaqc fix#106

Merged
wilsonsj100 merged 2 commits intomainfrom
qaqc-fix
Aug 29, 2025
Merged

ffi_qaqc fix#106
wilsonsj100 merged 2 commits intomainfrom
qaqc-fix

Conversation

@bpbond
Copy link
Member

@bpbond bpbond commented Aug 29, 2025

So, the problem documented in #104 was

  1. CRAN's R CMD CHECK runs the function examples
  2. The ffi_qaqc() example runs (#' x <- ffi_qaqc(fd, ...
  3. rmarkdown::render() is called within ffi_qaqc
  4. render generates some intermediate products in (by default) the working directory
  5. CRAN errors because you're not allowed to write there

This PR adds intermediates_dir = output_dir to the render call, which should fix things. I also fixed a syntax problem in the ffi_metadata_match documentation

Closes #104

@bpbond bpbond requested a review from wilsonsj100 August 29, 2025 18:56
@wilsonsj100
Copy link
Collaborator

Ah okay, so I missed one of the temp_dir's that we needed. Thank you for tracking this down!

@wilsonsj100 wilsonsj100 merged commit 9bacbc4 into main Aug 29, 2025
5 checks passed
Copy link
Collaborator

@wilsonsj100 wilsonsj100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense regarding the intermediate files. Thank you!

@wilsonsj100
Copy link
Collaborator

I guess we likely need to resubmit as 1.2.1 now that this has been changed - correct?

@bpbond
Copy link
Member Author

bpbond commented Aug 29, 2025

Hahaha yes don't forget the version number bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running examples in ‘fluxfinder-Ex.R’ failed

2 participants