Draft
Conversation
… least it is a start
Member
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
Definitely worth having a print warning for this. Left a few comments from a first read through.
|
|
||
| .PHONY: tool-version-check | ||
| tool-version-check: | ||
| echo "Expected version of cabal is 3.4.0.0 or higher; your version is `cabal --numeric-version`" |
Member
There was a problem hiding this comment.
How does this actually check the cabal version?
Collaborator
Author
There was a problem hiding this comment.
It does not check the version, it only does printing.
Makefile
Outdated
| # | ||
|
|
||
| all: vengines riscv-implementations | ||
| all: tool-version-check vengines riscv-implementations tool-version-check |
Member
There was a problem hiding this comment.
Why do you need to add this at the end as well as the beginning?
Collaborator
Author
There was a problem hiding this comment.
Good catch, I copied and forgot to delete one. Should not be fixed.
Collaborator
Author
|
I converted this to a draft PR as it is more a place holder for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this can be greatly improved, it is at least a start to know where thing start going wrong.