Skip to content

Added print for version checks #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
francislaus wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Added print for version checks #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5f33e3
Added print for version checks - this can be greatly improved, but at…
francislaus May 30, 2025
1849a0b
Removed double calling of tool-version-check in Makefile
francislaus Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,17 @@
# SUCH DAMAGE.
#

all: vengines riscv-implementations
all: tool-version-check vengines riscv-implementations

clean: clean-vengines clean-riscv-implementations

.PHONY: tool-version-check
tool-version-check:
echo "Expected version of cabal is 3.4.0.0 or higher; your version is `cabal --numeric-version`"
Copy link
Copy Markdown
Member

@marnovandermaas marnovandermaas May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this actually check the cabal version?

Copy link
Copy Markdown
Collaborator Author

@francislaus francislaus Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not check the version, it only does printing.


# Verification Engines
################################################################################
vengines: QCVEngine
vengines: tool-version-check QCVEngine

QCVENGINE_BIN_DIR=$(CURDIR)/vengines/QuickCheckVEngine/bin
QCVEngine: Makefile
Expand Down