[SanCov] Support SanitizerCoverage for CHERI purecap binaries #765
+57
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes type mismatches between uptr and usize.
This avoids the following errors:
<inline asm>:10:1: error: instruction requires the following: Not Capability Mode
10 | tail __interceptor_signal@plt
| ^
<inline asm>:19:1: error: instruction requires the following: Not Capability Mode
19 | tail __interceptor_sigaction@plt
|
RoundofThree
force-pushed
the
cheri-sancov
branch
from
f01ff23 to
f26d7d1
Compare
RoundofThree
changed the title
…n CHERI When multiple private sancov global variables across object files share the same name, even though they won't collide when they are linked together, their corresponding __cap_merged_table will. This commit appends a unique module identifier to the sancov global variable names to prevent collision. In the event that the unique module identifier obtained through getUniqueModuleId() is empty, we use the clang PID and time.
RoundofThree
force-pushed
the
cheri-sancov
branch
from
f26d7d1 to
c7b4afb
Compare
RoundofThree
changed the title
arichardson
requested changes
Aug 19, 2025
| uptr Len = sizeof(InfoProc); | ||
| CHECK_EQ(internal_sysctl(Mib, ARRAY_SIZE(Mib), nullptr, (uptr *)&InfoProc, &Len, 0), 0); | ||
| usize Len = sizeof(InfoProc); | ||
| CHECK_EQ(internal_sysctl(Mib, ARRAY_SIZE(Mib), &InfoProc, &Len, nullptr, 0), |
There was a problem hiding this comment.
This change looks good, would you mind send it upstream?
| #define SANITIZER_INTERCEPT_WCSDUP SI_POSIX | ||
| #define SANITIZER_INTERCEPT_SIGNAL_AND_SIGACTION (!SI_WINDOWS && SI_NOT_FUCHSIA) | ||
| #define SANITIZER_INTERCEPT_SIGNAL_AND_SIGACTION \ | ||
| (!SI_WINDOWS && SI_NOT_FUCHSIA && !SANITIZER_RISCV64) |
There was a problem hiding this comment.
This seems wrong, do you know what is causing those problems?
| auto Array = new GlobalVariable( | ||
| *CurModule, ArrayTy, false, GlobalVariable::PrivateLinkage, | ||
| Constant::getNullValue(ArrayTy), "__sancov_gen_"); | ||
| Constant::getNullValue(ArrayTy), |
There was a problem hiding this comment.
I don't understand why this change is needed? Also please avoid hardcoded AS200 checks and use DL.isFatPointer instead. But I am not convinced this change is actually required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for compiling purecap binaries with
-fsanitize-coverage.I have tested this in CHERI RISCV qemu.