Skip to content

[SanCov] Support SanitizerCoverage for CHERI purecap binaries #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
+57 −41
Open

[SanCov] Support SanitizerCoverage for CHERI purecap binaries #765

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b4aae6
[compiler-rt] Fix wrong internal_sysctl argument order in GetMemoryPr…
RoundofThree Apr 23, 2025
dd86799
[compiler-rt] Fix purecap compilation for CheriBSD
RoundofThree Apr 23, 2025
7b766aa
[compiler-rt] Don't intercept sigaction and signal for CHERI RISCV
RoundofThree Apr 23, 2025
c7b4afb
[SanCov] Fix sancov global symbol collision due to cap_merged_table i…
RoundofThree Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions compiler-rt/lib/sanitizer_common/sanitizer_procmaps_bsd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@ void GetMemoryProfile(fill_profile_f cb, uptr *stats) {
};

struct kinfo_proc InfoProc;
uptr Len = sizeof(InfoProc);
CHECK_EQ(internal_sysctl(Mib, ARRAY_SIZE(Mib), nullptr, (uptr *)&InfoProc, &Len, 0), 0);
usize Len = sizeof(InfoProc);
CHECK_EQ(internal_sysctl(Mib, ARRAY_SIZE(Mib), &InfoProc, &Len, nullptr, 0),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good, would you mind send it upstream?

0);
cb(0, InfoProc.ki_rssize * GetPageSizeCached(), false, stats);
}
#endif
Expand Down