Potential fix for code scanning alert no. 79: Missed opportunity to use Select #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se Select Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Caliburn-Micro/Caliburn.Micro/security/code-scanning/79
To fix the problem, rewrite the
foreach (var item in items)loop inside theRemoveRangelocal function (lines 253-260 inRemoveRange(IEnumerable<T> items)) to iterate directly over the indexes generated from the items using LINQ's.Select(item => IndexOf(item)). For each index, perform the conditional check and potential removal as before. This is accomplished by changing the loop toforeach (var index in items.Select(item => IndexOf(item))). Ensure that System.Linq is imported (if not already present) for.Selectto function.Edit only the affected method in
src/Caliburn.Micro.Core/BindableCollection.cs, specifically lines 253-260 withinRemoveRange(). No new method definitions are required. Double-check thatusing System.Linq;is imported at the top of the file (in the provided lines, it is not), so add it.Suggested fixes powered by Copilot Autofix. Review carefully before merging.