Skip to content

Potential fix for code scanning alert no. 79: Missed opportunity to use Select #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 79: Missed opportunity to use Select #1026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Caliburn.Micro.Core/BindableCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
using System.Collections.ObjectModel;
using System.Collections.Specialized;
using System.ComponentModel;

using System.Linq;
namespace Caliburn.Micro
{
/// <summary>
Expand Down Expand Up @@ -250,14 +250,13 @@
{
var previousNotificationSetting = IsNotifying;
IsNotifying = false;
foreach (var item in items)
foreach (var index in items.Select(item => IndexOf(item)))
{
var index = IndexOf(item);
if (index >= 0)
{
RemoveItemBase(index);
}
}

Check notice

Code scanning / CodeQL

Missed opportunity to use Where Note

This foreach loop
implicitly filters its target sequence
Loading
- consider filtering the sequence explicitly using '.Where(...)'.
IsNotifying = previousNotificationSetting;

OnPropertyChanged(new PropertyChangedEventArgs("Count"));
Expand Down
Loading