Support overriding base image via build arg#571
Merged
yaronkoren merged 2 commits intomasterfrom Jan 26, 2026
Merged
Conversation
Add BASE_IMAGE build arg to allow building Canasta with a custom CanastaBase image. This enables the Canasta CLI's --build-from flag to build both CanastaBase and Canasta from local source repositories. Default behavior is unchanged (uses ghcr.io/canastawiki/canasta-base:1.0.7).
This was referenced Jan 26, 2026
The Dockerfile now uses an ARG for the base image instead of hardcoding it in the FROM line. Update the awk command to parse the default value from the ARG line.
|
🐳 The image based on 81238521 commit has been built with |
cicalese
requested review from
naresh-kumar-babu,
sanjay-thiyagarajan and
yaronkoren
yaronkoren
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add BASE_IMAGE build arg to allow building Canasta with a custom CanastaBase image. This enables the Canasta CLI's --build-from flag to build both CanastaBase and Canasta from local source repositories.
Default behavior is unchanged (uses ghcr.io/canastawiki/canasta-base:1.0.7).
Related PRs: