Skip to content

Fix symlink creation for mounted directories#54

Merged
yaronkoren merged 2 commits intomasterfrom
symlink2
Jan 26, 2026
Merged

Fix symlink creation for mounted directories#54
yaronkoren merged 2 commits intomasterfrom
symlink2

Conversation

@cicalese
Copy link
Contributor

@cicalese cicalese commented Jan 26, 2026

The previous symlink creation could fail when target directories already exist (e.g., in dev mode where code is extracted and mounted).

Changes:

  • Remove existing directories before creating symlinks
  • Use ln -sfn for all symlink operations to properly replace symlinks to directories
  • Apply fix to bundled extensions/skins, not just user extensions/skins

Related PRs:

The previous symlink creation could fail when target directories
already exist (e.g., in dev mode where code is extracted and mounted).

Changes:
- Remove existing directories before creating symlinks
- Use ln -sfn for all symlink operations to properly replace
  symlinks to directories
- Apply fix to bundled extensions/skins, not just user extensions/skins
@github-actions
Copy link

🐳 The image based on 50f59b20 commit has been built with 1.43.6-20260126-54 tag as ghcr.io/canastawiki/canasta-base:1.43.6-20260126-54

@yaronkoren yaronkoren merged commit 6483e23 into master Jan 26, 2026
2 checks passed
@cicalese cicalese deleted the symlink2 branch January 26, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants