Skip to content

Conversation

@GurrenLagannTSS
Copy link
Contributor

@GurrenLagannTSS GurrenLagannTSS commented Feb 5, 2021

Partially implements and closes #901.
Also added temperatures for WNh stars as a workaround, avaiable when using luminosity classes II, I-a, I-b, and I-a0 for WN-class stars.

@375gnu
Copy link
Collaborator

375gnu commented Feb 6, 2021

  1. All commits should be squashed into a single one
  2. Reference to the sources should be left in comments so we can validate temperatures and so on

@Trolligi112477-ww
Copy link

Sources: https://arxiv.org/pdf/1904.04687.pdf
https://arxiv.org/pdf/1807.04293.pdf
Wikipedia
Logic

oh wait... maybe the WN5-WN6 temps should be lowered

@SevenSpheres SevenSpheres self-requested a review February 7, 2021 17:14
@375gnu 375gnu marked this pull request as draft January 25, 2022 22:11
@375gnu 375gnu force-pushed the master branch 2 times, most recently from 690ab56 to 2f8f3b0 Compare May 15, 2023 19:57
@AstroChara
Copy link
Contributor

Hang on, what's the current issue with this thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proper WR temperatures

5 participants