Skip to content

Add proper temperatures for WC and WN stars #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add proper temperatures for WC and WN stars #913

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34ca7d9
Add proper temperatures for WC and WN stars
GurrenLagannTSS Feb 5, 2021
ce67173
Update star.cpp
GurrenLagannTSS Feb 5, 2021
ff5adc6
Update star.cpp
GurrenLagannTSS Feb 5, 2021
084942d
Added WNh temperatures in a workaround..
GurrenLagannTSS Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/celengine/star.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,19 @@ static float tempM[3][10] =
{ 3650, 3550, 3450, 3200, 2980, 2800, 2600, 2600, 2600, 2600 },
};

// Wolf-Rayet temperatures. From Lang's Astrophysical Data: Planets and
// Stars.
static float tempWN[10] =
// Wolf-Rayet temperatures.
static float tempWN[3][10] =
{
50000, 50000, 50000, 50000, 47000, 43000, 39000, 32000, 29000, 29000
{ 185000, 158000, 140000, 115000, 89000, 75000, 65000, 56000, 50000, 45000 },
{ 185000, 158000, 140000, 115000, 89000, 75000, 65000, 56000, 50000, 45000 },
// WNh stars. Currently as a workaround until its split into its own class.
{ 133000, 106000, 92000, 72000, 61000, 51000, 42000, 36000, 31000, 27000 },
};

// Note: The temperatures for early and late WCs are mostly for CSPNe.
static float tempWC[10] =
{
60000, 60000, 60000, 60000, 60000, 60000, 60000, 54000, 46000, 38000
225000, 190000, 165000, 140000, 125000, 105000, 83000, 70000, 58000, 46000
};

// These values are based on extrapolation of 6 samples.
Expand Down Expand Up @@ -566,7 +569,7 @@ StarDetails::GetNormalStarDetails(StellarClass::SpectralClass specClass,
temp = tempM[lumIndex][subclass];
break;
case StellarClass::Spectral_WN:
temp = tempWN[subclass];
temp = tempWN[lumIndex][subclass];
break;
case StellarClass::Spectral_WC:
temp = tempWC[subclass];
Expand Down