Skip to content

[ENG-6567][ENG-6598] Fix dropdown placement for mobile #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
futa-ikeda merged 2 commits into from
Nov 20, 2024
Merged

[ENG-6567][ENG-6598] Fix dropdown placement for mobile #2408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1be036e
Fix dropdown placement for mobile
futa-ikeda Nov 20, 2024
3c38cb0
a11y fix for items per page dropdown
futa-ikeda Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/institutions/dashboard/-components/institutional-users-list/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@

&.mobile {
max-width: none;
right: 100%;
}
}

Expand Down
17 changes: 10 additions & 7 deletions lib/osf-components/addon/components/adjustable-paginator/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
<span local-class='paginator__control'>
<div local-class='paginator__select-wrapper'>
<select title={{t 'paginator.itemsPerPage'}} local-class='paginator__select' onchange={{action this.onPageSizeChange value='target.value'}}>
{{#each this.pageSizeOptions as |page_size_option|}}
<option value={{page_size_option}} selected={{eq page_size_option this.selectedPageSize}}>
{{t 'paginator.itemsPerPage'}} {{page_size_option}}
</option>
{{/each}}
</select>
<label>
{{t 'paginator.itemsPerPage'}}
<select local-class='paginator__select' onchange={{action this.onPageSizeChange value='target.value'}}>
{{#each this.pageSizeOptions as |page_size_option|}}
<option value={{page_size_option}} selected={{eq page_size_option this.selectedPageSize}}>
{{page_size_option}}
</option>
{{/each}}
</select>
</label>
</div>
</span>

Expand Down
Loading