Skip to content

Conversation

@cslzchen
Copy link
Collaborator

@cslzchen cslzchen commented Jun 26, 2025

Purpose

Verified Resource Linking - FE Part

Summary of Changes

VRL

  • Update ember data to supported linked services, a new type of add-on LINK
  • Added new linked services page to the Ember project page which lists a project's linked services includes icon, name, resource type and the link.
    • In addition: edit button shows up if user has the right permission for user to reconfigure or remove the add-on
    • Legacy project page: new "Linked Services" link in top nav bar which redirects to this page when clicked
  • New work flow for configure linked services add-on for project, with Dataverse as current implementation
  • New work flow for connect linked services account for user settings, with Dataverse as current implementation
  • Unit tests fixes + mirage update

For details, see mock-ups and/or try it on https://staging.osf.io/

Bonus (i.e. affects all add-ons)

  • Allow finer-grained routing options within the project's add-ons page
  • Don't created configured add-on pre-maturely

Screenshot(s)

N/A

Side Effects

N/A

QA Notes

N/A

adlius and others added 25 commits April 17, 2025 01:56
* add query params for routing

* fix tests

* fix stuck tests
* preliminary

* another batch of updates

* moar

* fix tests

* settings page

* CR followup
* linked services project page + bug fixes

* add edit button

* fix tests
…when no verified linked service is connected (#2582)
@coveralls
Copy link

coveralls commented Jun 26, 2025

Pull Request Test Coverage Report for Build 16118219201

Details

  • 40 of 112 (35.71%) changed or added relevant lines in 16 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 67.207%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/guid-node/links/controller.ts 0 1 0.0%
app/models/configured-addon.ts 0 1 0.0%
lib/osf-components/addon/components/addons-service/file-manager/component.ts 0 1 0.0%
app/models/configured-citation-addon.ts 0 2 0.0%
app/helpers/instance-of.ts 5 8 62.5%
lib/osf-components/addon/components/addons-service/terms-of-service/component.ts 0 3 0.0%
app/guid-node/links/route.ts 0 5 0.0%
app/models/authorized-link-account.ts 0 6 0.0%
lib/osf-components/addon/components/addons-service/configured-addon-edit/component.ts 20 26 76.92%
app/models/configured-link-addon.ts 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
lib/osf-components/addon/components/addons-service/manager/component.ts 3 54.65%
Totals Coverage Status
Change from base Build 15688718112: -0.2%
Covered Lines: 8536
Relevant Lines: 12231

💛 - Coveralls

@cslzchen cslzchen changed the title [Draft] VRL - FE [ENG-6835] [ENG-8060] [ENG-8289] VRL Project PR - FE Jun 27, 2025
@cslzchen cslzchen marked this pull request as ready for review June 27, 2025 02:54
@cslzchen cslzchen requested a review from brianjgeiger June 27, 2025 02:54
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions, and a couple of minor suggestions.

brianjgeiger
brianjgeiger previously approved these changes Jul 3, 2025
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could still use a tiny bit of redundancy removed, but that's not a blocker to release. Try to get it in, though, please.

@cslzchen cslzchen merged commit f4800aa into develop Jul 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants