-
Notifications
You must be signed in to change notification settings - Fork 64
[ENG-6835] [ENG-8060] [ENG-8289] VRL Project PR - FE #2595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* add query params for routing * fix tests * fix stuck tests
…-resource-linking
…ourceTypeGeneral (#2555)
* preliminary * another batch of updates * moar * fix tests * settings page * CR followup
…-resource-linking
* linked services project page + bug fixes * add edit button * fix tests
…dd-on is configured (#2574)
…when no verified linked service is connected (#2582)
…linked services (#2587)
… linked service page for mobile (#2593)
…rse account is empty (#2588)
…-resource-linking
brianjgeiger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions, and a couple of minor suggestions.
lib/osf-components/addon/components/addons-service/configured-addon-edit/component.ts
Outdated
Show resolved
Hide resolved
brianjgeiger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could still use a tiny bit of redundancy removed, but that's not a blocker to release. Try to get it in, though, please.
Purpose
Verified Resource Linking - FE Part
Summary of Changes
VRL
LINKFor details, see mock-ups and/or try it on https://staging.osf.io/
Bonus (i.e. affects all add-ons)
Screenshot(s)
N/A
Side Effects
N/A
QA Notes
N/A