Skip to content

[hotfix/26.1.5] [ENG-10027] Fix broken review links in moderation digest for preprints & registrations #11537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cslzchen merged 1 commit into from
Jan 8, 2026
+7 −10
Merged

[hotfix/26.1.5] [ENG-10027] Fix broken review links in moderation digest for preprints & registrations #11537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion notifications/listeners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def reviews_withdraw_requests_notification_moderators(self, timestamp, context,
# Set message
context['message'] = f'has requested withdrawal of "{resource.title}".'
# Set submission url
context['reviews_submission_url'] = f'{DOMAIN}reviews/registries/{provider._id}/{resource._id}'
context['reviews_submission_url'] = f'{DOMAIN}registries/{provider._id}/{resource._id}?mode=moderator'
context['localized_timestamp'] = str(timestamp)
NotificationType.Type.PROVIDER_NEW_PENDING_WITHDRAW_REQUESTS.instance.emit(
subscribed_object=provider,
Expand Down
15 changes: 6 additions & 9 deletions website/reviews/listeners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def reviews_withdraw_requests_notification_moderators(self, timestamp, context,
from osf.models import NotificationType

context['message'] = f'has requested withdrawal of "{resource.title}".'
context['reviews_submission_url'] = f'{DOMAIN}reviews/registries/{provider._id}/{resource._id}'
context['reviews_submission_url'] = f'{DOMAIN}registries/{provider._id}/{resource._id}?mode=moderator'

context['provider_id'] = provider.id
for group_name in ['moderator', 'admin']:
Expand Down Expand Up @@ -60,7 +60,7 @@ def reviews_withdrawal_requests_notification(self, timestamp, context):

preprint_word = preprint.provider.preprint_word
context['message'] = f'has requested withdrawal of the {preprint_word} "{preprint.title}".'
context['reviews_submission_url'] = f'{DOMAIN}reviews/preprints/{preprint.provider._id}/{preprint._id}'
context['reviews_submission_url'] = f'{DOMAIN}preprints/{preprint.provider._id}/{preprint._id}?mode=moderator'

context['provider_id'] = preprint.provider.id
for group_name in ['moderator', 'admin']:
Expand All @@ -85,16 +85,13 @@ def reviews_submit_notification_moderators(self, timestamp, resource, context):

provider = resource.provider
context['provider_id'] = provider.id
context['reviews_submission_url'] = (
f'{DOMAIN}reviews/preprints/{provider._id}/{resource._id}'
)
context['reviews_submission_url'] = f'{DOMAIN}preprints/{provider._id}/{resource._id}?mode=moderator'

# Set submission url
if provider.type == 'osf.preprintprovider':
context['reviews_submission_url'] = (
f'{DOMAIN}reviews/preprints/{provider._id}/{resource._id}'
)
context['reviews_submission_url'] = f'{DOMAIN}preprints/{provider._id}/{resource._id}?mode=moderator'
elif provider.type == 'osf.registrationprovider':
context['reviews_submission_url'] = f'{DOMAIN}{resource._id}?mode=moderator'
context['reviews_submission_url'] = f'{DOMAIN}registries/{provider._id}/{resource._id}?mode=moderator'
else:
raise NotImplementedError(f'unsupported provider type {provider.type}')

Expand Down
Loading