[hotfix/26.1.5] [ENG-10027] Fix broken review links in moderation digest for preprints & registrations #11537
Conversation
| context['message'] = f'has requested withdrawal of "{resource.title}".' | ||
| # Set submission url | ||
| context['reviews_submission_url'] = f'{DOMAIN}reviews/registries/{provider._id}/{resource._id}' | ||
| context['reviews_submission_url'] = f'{DOMAIN}registries/{provider._id}/{resource._id}?mode=moderator' |
There was a problem hiding this comment.
- Does this one in
notifications/listeners.pyduplicates with the one inwebsite/reviews/listeners.py? - A follow-up question is why listeners are in two different places?
There was a problem hiding this comment.
Yes, these appear to be duplicates. One located in notifications/listeners.py should be removed.
There was a problem hiding this comment.
I believe notifications/listeners.py was created to serve as an easily accessible location for notification signals. However, it looks like we decided not to move everything there at some point, yet the duplicates were never removed.
There was a problem hiding this comment.
@Ostap-Zherebetskyi and @bodintsov
It seems our unit tests may have been using the wrong signal or both signals are being used, see failures: https://github.com/CenterForOpenScience/osf.io/actions/runs/20826183331/job/59828027689?pr=11537 so I removed the commit for removing this signal. I had problem with mailhog connection when running unit tests locally, so I will create another ticket for merging/fixing the two duplicate signals.
Ostap-Zherebetskyi
left a comment
Ostap-Zherebetskyi
left a comment
There was a problem hiding this comment.
Should the "reviews_submission_url" for collections have the same change?
It's LGTM after the comments are resolved.
cslzchen
force-pushed
the
hotfix/fix-link-in-moderator-withdrawal-email
branch
2 times, most recently
from
2e01adf to
afdf68f
Compare
cslzchen
changed the title
cslzchen
changed the title
3 participants
Ticket
Purpose
Fix link in moderator digest emails
Changes
Remove a duplicate and unused signalSide Effects
N/A
QE Notes
CE Notes
N/A
Documentation
N/A