Improve setup override logic for processed property handling in GraphRepository #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in the
GraphRepository, thesetupmethod is overridden to call_setup_properties()after the processed data is available:This override introduces a couple of issues:
Bypassing the setup flag:
The base class uses
_setup_data_flagto prevent multiple invocations of thesetup()method:Overriding
setup()in the derived class causes this mechanism to be bypassed or duplicated unintentionally.Manual control over reader finalization:
To prevent
reader.on_finish()from executing before_setup_properties()is complete, the derived class needs to manually passkeep_reader=Trueto the basesetup()method. This adds unnecessary complexity and tight coupling between the base and derived classes.✅ Proposed Solution: Introduce
_after_setup()hook in the base classTo resolve these issues cleanly, introduce an
_after_setup(**kwargs)method in the base class. This hook would be called after data preprocessing and flag updates are completed:Base class:
GraphRepository subclass:
This change enables:
_setup_properties().