Fix schedule_all_controllers to skip INVALID controllers when enabling#400
Merged
Chaffelson merged 1 commit intomainfrom Jan 8, 2026
Merged
Fix schedule_all_controllers to skip INVALID controllers when enabling#400Chaffelson merged 1 commit intomainfrom
Chaffelson merged 1 commit intomainfrom
Conversation
When enabling controller services, NiFi server correctly skips INVALID controllers (those that cannot be enabled due to validation errors). The client was incorrectly waiting for ALL controllers to reach ENABLED state, causing a 30-second timeout when any controller was INVALID. Now the polling logic only waits for VALID controllers when enabling. When disabling, all controllers are still checked since any controller can be disabled regardless of validation status. Adds test for mixed VALID/INVALID controller scenario.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
==========================================
+ Coverage 76.45% 76.50% +0.04%
==========================================
Files 41 41
Lines 4732 4737 +5
==========================================
+ Hits 3618 3624 +6
+ Misses 1114 1113 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabling controller services, NiFi server correctly skips INVALID controllers (those that cannot be enabled due to validation errors). The client was incorrectly waiting for ALL controllers to reach ENABLED state, causing a 30-second timeout when any controller was INVALID.
Now the polling logic only waits for VALID controllers when enabling. When disabling, all controllers are still checked since any controller can be disabled regardless of validation status.
Adds test for mixed VALID/INVALID controller scenario.