Skip to content

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Nov 10, 2025

Summary of changes

Changes introduced in this pull request:

  • upgrade tool to 1.91.0
  • cargo update

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code
    adheres to the team's
    documentation standards,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes
    should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Updated Rust toolchain version to 1.91.0.

@hanabi1224 hanabi1224 requested a review from a team as a code owner November 10, 2025 11:22
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Walkthrough

Updates the Rust toolchain version from 1.89.0 to 1.91.0 in rust-toolchain.toml. All components and targets remain unchanged with no behavioral modifications.

Changes

Cohort / File(s) Summary
Rust toolchain update
rust-toolchain.toml
Version bump: 1.89.0 → 1.91.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

dependencies, rust

Suggested reviewers

  • LesnyRumcajs
  • sudo-shashank

Poem

🐰 A rabbit hops with glee,
The toolchain's fresh—1-9-1!
From ancient 89, we flee,
New Rust has just begun! 🦀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title contains a typo ('ugprade' instead of 'upgrade') but clearly describes the main change: updating the Rust toolchain version. The title is specific and related to the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hm/rust-1.91

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f88cd42 and dbb38f5.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • rust-toolchain.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: lint
  • GitHub Check: codedov
  • GitHub Check: E2E API Tests
  • GitHub Check: deploy
  • GitHub Check: E2E Claim Token API CORS Tests
  • GitHub Check: E2E Browser Tests
🔇 Additional comments (2)
rust-toolchain.toml (2)

2-2: Cargo.lock was successfully updated in the commit—no action required.

Note: Be aware that libraries in /usr/local/lib may no longer be linked automatically in 1.91.0, which may require adjustments to build.rs if your project relies on this.


2-2: Build verification confirms Rust 1.91.0 compatibility—no blocking issues detected.

Analysis of the three breaking changes in Rust 1.91.0 shows your codebase is not affected:

  • semicolon_in_expressions_from_macros (deny-by-default): The lotus_json_with_self macro generates clean trait implementations without problematic semicolons in expressions.
  • Pattern bindings drop order: Pattern bindings in the codebase are simple tuple destructuring (let (var1, var2) = ...), not complex destructors sensitive to drop ordering.
  • FFI ABI stabilization: No FFI code found using the affected ABIs (sysv64, win64, efiapi, aapcs).

To fully confirm, run cargo build && cargo test with the new toolchain to verify compilation and test suite success.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.09%. Comparing base (f88cd42) to head (dbb38f5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #352   +/-   ##
=======================================
  Coverage   41.09%   41.09%           
=======================================
  Files          40       40           
  Lines        2667     2667           
=======================================
  Hits         1096     1096           
  Misses       1571     1571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Nov 10, 2025
Merged via the queue into main with commit 3d3d0c5 Nov 10, 2025
7 checks passed
@LesnyRumcajs LesnyRumcajs deleted the hm/rust-1.91 branch November 10, 2025 11:43
@coderabbitai coderabbitai bot mentioned this pull request Dec 12, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants