Use certifi wheel instead of the mozilla-ca submodule
#19837
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardkiss
added
the
Changed
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
I have to admit I don't know what to try to exercise the code affected by this. Seems like it's farm & pool related. |
altendky
reviewed
Jul 16, 2025
There was a problem hiding this comment.
i (presently) have no input to give on the reasons that mozilla-ca is preferred.
here's a few nitpicky comments anyways.
i do abstractly prefer this proposed form of depending on a common package instead of submoduling a thing and publishing two top level import packages in our distribution package.
|
Using #19850 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Current Behavior:
New Behavior:
Testing Notes: