Skip to content

Change minimium node version to 20 and npm version to 10 #19845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 18, 2025
Merged

Change minimium node version to 20 and npm version to 10 #19845

merged 4 commits into from
Jul 18, 2025

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Jul 17, 2025 •
edited
Loading

Update minimum node version to 20 and npm version to 10
Also update version of n to be 10.2.0

@socket-security Socket Security
Copy link

socket-security bot commented Jul 17, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​n@​8.2.0 ⏵ 10.2.01001009386100

View full report

@emlowe emlowe changed the title Change minimium node version to 20 Change minimium node version to 20 and npm version to 10 Jul 17, 2025
@emlowe emlowe added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jul 17, 2025
@emlowe emlowe requested review from ChiaMineJP and seeden July 17, 2025 20:18
@emlowe emlowe marked this pull request as ready for review July 17, 2025 20:47
@emlowe emlowe requested review from a team as code owners July 17, 2025 20:47
seeden
seeden previously approved these changes Jul 17, 2025
View reviewed changes
ChiaMineJP
ChiaMineJP requested changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@ChiaMineJP ChiaMineJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than 1 request change, it looks good to me

@seeden seeden requested a review from ChiaMineJP July 18, 2025 14:01
ChiaMineJP
ChiaMineJP requested changes Jul 18, 2025
View reviewed changes
@seeden seeden requested a review from ChiaMineJP July 18, 2025 14:12
@seeden seeden self-requested a review July 18, 2025 15:48
@Starttoaster Starttoaster merged commit 8b8035f into release/2.5.5 Jul 18, 2025
1527 of 1531 checks passed
@Starttoaster Starttoaster deleted the EL.node-20 branch July 18, 2025 16:26
Starttoaster added a commit that referenced this pull request Jul 28, 2025
@Starttoaster @emlowe @seeden
checkpoint: into main from release/2.5.5 @ 8b8035f (#19862)
eb1e054 
Change minimium node version to 20 and npm version to 10 (#19845)

* Update to node 20

* Update another script for minimum npm version

* update check for npm >= 10

* update npm version

---------

Co-authored-by: Earle Lowe <[email protected]>
Co-authored-by: Zlatko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seeden seeden seeden approved these changes

@Starttoaster Starttoaster Starttoaster approved these changes

@markelrod markelrod markelrod approved these changes

@ChiaMineJP ChiaMineJP ChiaMineJP approved these changes

Assignees

No one assigned

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@emlowe @seeden @Starttoaster @markelrod @ChiaMineJP