Skip to content

chore: fix some minor issues in comment #19980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some minor issues in comment #19980

wants to merge 1 commit into from
+4 −4

Conversation

deepdring
Copy link

Purpose:

fix some minor issues in comment

Current Behavior:

New Behavior:

Testing Notes:

@deepdring deepdring requested a review from a team as a code owner August 21, 2025 12:13
@deepdring
Copy link
Author

Your commits are not signed and our branch protection rules require signed commits. For more information on how to create signed commits, please visit this page: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification. Please use the button towards the bottom of the page to close this pull request and open a new one with signed commits.

Thanks. Signed.

image

@deepdring
Copy link
Author

@Starttoaster @emlowe Hi, Cloud you please review this PR? Thanks

emlowe
emlowe requested changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI cannot pass with your current changes

@deepdring
Copy link
Author

@emlowe Thanks for your reply!

Reverted. Please review it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
community-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepdring @emlowe @ChiaAutomation