Add julia_version = 1 conversion and run resolver with Base.julia_cmd#1
Merged
ChrisRackauckas-Claude merged 1 commit intoChrisRackauckas-Claude:fix-test-project-toml-local-sourcesfrom Jan 21, 2026
Conversation
Merged
3 tasks
Author
|
@ChrisRackauckas, could you take a look at this, please? |
3a2ce92
into
ChrisRackauckas-Claude:fix-test-project-toml-local-sources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really want to get this done, such that this GitHub action is able to achieve the same results as v1 of the action. So I looked again at fixing julia-actions#37 (comment). If I understand correctly, there are two independent issues:
julia_version: 1? julia-actions/julia-downgrade-compat#25, settingjulia_version = 1is currently interpreted as "any julia version 1.x.y". That's probably not what most people want when they setjulia_version = 1. In this PR, I simply set it toVERSION. Alternatively, on could set it to the latest version.ERROR: LoadError: could not find source path for package MbedTLS_jllwhen running with julia v1.10. This is caused by the fact the julia process, which runs Resolver.jl currently simply usesjuliain the cmd, i.e., the latest available julia version (in this case julia v1.12). This leads to mismatches and thus the error (we can also see the reference to julia v1.12 in the stacktrace). Again, we have two options: Either we use the version, which was used to run the action or we usejulia_version. Here, I opted for the first option by utilizingBase.julia_cmd().This fixes julia-actions#25 and the problems described in julia-actions#37 (comment) (I still do not recover the same behavior as in v1, but I will explain that in the other PR).