Skip to content

Add julia_version = 1 conversion and run resolver with Base.julia_cmd #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas-Claude merged 1 commit into from
Jan 21, 2026
Merged

Add julia_version = 1 conversion and run resolver with Base.julia_cmd #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions downgrade.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ dirs = filter(!isempty, map(strip, split(ARGS[2], ",")))
mode = length(ARGS) >= 3 ? ARGS[3] : "deps"
julia_version = length(ARGS) >= 4 ? ARGS[4] : "1.10"

# Convert "1" to the current running Julia version (e.g., "1.12" for Julia 1.12.3)
# This ensures the resolved manifest matches the Julia version that will read it
if julia_version == "1"
julia_version = string(VERSION.major, ".", VERSION.minor)
@info "Converted julia_version \"1\" to \"$julia_version\" (current Julia version)"
end

valid_modes = ["deps", "alldeps", "weakdeps", "forcedeps"]
mode in valid_modes || error("mode must be one of: $(join(valid_modes, ", "))")

Expand Down Expand Up @@ -282,7 +289,7 @@ function resolve_directory(

try
@info "Running resolver on $dir with --min=@$resolver_mode"
run(`julia --project=$resolver_path/bin $resolver_path/bin/resolve.jl $dir --min=@$resolver_mode --julia=$julia_version`)
run(`$(Base.julia_cmd()) --project=$resolver_path/bin $resolver_path/bin/resolve.jl $dir --min=@$resolver_mode --julia=$julia_version`)
@info "Successfully resolved minimal versions for $dir"
finally
# Always restore the original Project.toml, even if resolution fails
Expand Down Expand Up @@ -343,7 +350,7 @@ resolver_path = mktempdir()
@info "Cloning Resolver.jl"
run(`git clone https://github.com/StefanKarpinski/Resolver.jl.git $resolver_path`)
# Install dependencies
run(`julia --project=$resolver_path/bin -e "using Pkg; Pkg.instantiate()"`)
run(`$(Base.julia_cmd()) --project=$resolver_path/bin -e "using Pkg; Pkg.instantiate()"`)

"""
get_lower_bounds(project_file, ignore_pkgs)
Expand Down Expand Up @@ -525,7 +532,7 @@ if do_merge

# Run resolver on merged project
@info "Running resolver on merged project with --min=@$resolver_mode"
run(`julia --project=$resolver_path/bin $resolver_path/bin/resolve.jl $merged_dir --min=@$resolver_mode --julia=$julia_version`)
run(`$(Base.julia_cmd()) --project=$resolver_path/bin $resolver_path/bin/resolve.jl $merged_dir --min=@$resolver_mode --julia=$julia_version`)
@info "Successfully resolved minimal versions for merged project"

# Copy manifest to main project directory
Expand Down