-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Integrate CrUX data into performance trace summaries #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paulirish
wants to merge
21
commits into
main
Choose a base branch
from
crux-for-trace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+161
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ibda3954500250fa9c2d0ae95dd996409ea525080
Change-Id: Ib9b76305409bb660a25182497d9b54591e2297a0
Change-Id: I3886ba86705ce423ccf8024133bc58fff16fa6c8
Change-Id: I921880b40788863151962d13dc9838c4793a840f
Change-Id: I94c55d08bad7c58b28a5febccdc126dc0b012e5f
Change-Id: I70fa78a46ebb1bc43be66dcd80177cec2ab34f1c
Change-Id: Id8ff5120b5f02cd57ed42427b182763afbf65dff
Change-Id: I22e211eebdca6bf25878cb4dd4182d9b6ca34cf8
Change-Id: Ie1905a1b746cce82b27dfe89c56d2b591c050291
Change-Id: I331aa991818b151e7b4080490475736afd30120f
Change-Id: I2e45c268b8510658b4ece06f52a7bd67b5154b2a
Change-Id: I04829e52b7e38bf4384b6db89f977abe518d7b5e
Change-Id: I5e824dbb077b94accb65420d97f5fc3de61fbd53
Change-Id: I8eff31fd3b8d01f7ac466ed22117696844227ac4
Change-Id: I5b9c78336bf0d7ca8ae42f62fc59bfe28da628ee
361e595 to
4cef374
Compare
Collaborator
|
@paulirish I have updated the devtools-frontend dependency today so it should be ready to be rebased |
Change-Id: Ib6eacf5cc90e858b3c2cbce67ceb41f4d35b0065
Member
Author
Danke! It's up to date now. |
OrKoN
reviewed
Jan 15, 2026
| c.url.toString(), | ||
| ); | ||
| urls.push(result.parsedTrace.data.Meta.mainFrameURL); | ||
| const urlSet = new Set(urls); |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this exclude localhost URLs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We upgrade the performance trace tools to include real-user experience data from the Chrome User Experience Report (CrUX).
https://developer.chrome.com/docs/crux
https://developer.chrome.com/docs/crux/methodology
Deets
Privacy Considerations:
Doc: go/crux-in-bifrost
Fixes b/446630695