-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Integrate CrUX data into performance trace summaries #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paulirish
wants to merge
21
commits into
main
Choose a base branch
from
crux-for-trace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+161
−6
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
be31b47
revert these lockfile changes
paulirish 9623ae6
implemented but imma change it
paulirish 31a6cf1
collapsed to a single setting
paulirish 1f17741
remove toggle tool. bump up timeouts while i investigate them
paulirish de66b44
ensureCrux for test
paulirish a2894a9
manual test yayyyyyyyyyyy
paulirish e2da11a
universe mgr added to ctx
paulirish 7e71d8f
settings is resolve but now we need to give cruxmgr some data to report
paulirish 647f0d9
drop util crux. trying to get proper data from real thing
paulirish eb5bc51
new endpoint. will work when i tweak api in GCP C
paulirish 94ac77c
Merge branch 'main' into crux-for-trace
paulirish 44687f9
Merge remote-tracking branch 'origin/main' into crux-for-trace
paulirish 7d8ae17
works
paulirish 9280192
mock fetch to avoid network RT in test
paulirish 295b192
drop diff
paulirish 1662b6d
use proper export
paulirish 4cef374
prep for crrev.com/c/7421201
paulirish a64ee0b
Merge branch 'main' into crux-for-trace
paulirish d892a26
Merge branch 'main' into crux-for-trace
paulirish 009064a
skip manager? nahh
paulirish 53736f5
Merge branch 'main' into crux-for-trace
paulirish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this exclude localhost URLs?