Remove locale:missing; standardise on locale:download:missing by Copilot · Pull Request #8204 · ChurchCRM/CRM

Copilot · 2026-03-06T15:41:31Z

The local-diff approach (locale-build-missing.js / locale:missing) was redundant — POEditor's own filters=untranslated export API already computes missing terms server-side with no prior full download required. This removes the old script and wires everything to locale:download:missing.

Changes

Deleted locale/scripts/locale-build-missing.js
package.json — removed locale:missing script
locale/scripts/locale-translate.js — updated fallback hint to locale:download:missing
locale/scripts/poeditor-missing-downloader.js — cleaned up JSDoc (dropped cross-references to deleted file)
locale/README.md — collapsed two-option workflow to single canonical approach; removed locale:missing from scripts table and quick-reference block
.github/workflows/locale-poeditor-download.yml — replaced npm run locale:missing step with npm run locale:download:missing; updated commit step paths from locale/missing-terms/poeditor-*.json → locale/terms/missing/
.agents/skills/churchcrm/locale-ai-translation.md and .claude/commands/locale-release.md — Quick Start and scripts table updated to locale:download:missing

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…d:missing) Uses POEditor filters=untranslated to download only untranslated terms per locale directly from the API, without needing a full locale:download first. - New: locale/scripts/poeditor-missing-downloader.js - New npm script: locale:download:missing - Updated: locale/README.md (documents both methods) - Updated: .agents/skills/churchcrm/locale-ai-translation.md skill docs Co-authored-by: DawoudIO <554959+DawoudIO@users.noreply.github.com>

- Delete locale/scripts/locale-build-missing.js - Remove locale:missing npm script from package.json - Update locale-translate.js error hint to locale:download:missing - Update poeditor-missing-downloader.js JSDoc (remove ref to deleted file) - Update locale/README.md, locale-ai-translation.md skill, locale-release.md Co-authored-by: DawoudIO <554959+DawoudIO@users.noreply.github.com>

locale/scripts/poeditor-missing-downloader.js

- Replace npm run locale:missing with npm run locale:download:missing - Update commit step path from locale/missing-terms/ to locale/terms/missing/ - Update PR body references to new path Co-authored-by: DawoudIO <554959+DawoudIO@users.noreply.github.com>

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Copilot

Pull request overview

This PR removes the redundant local diff–based missing-terms generator (locale:missing) and standardizes the workflow on downloading untranslated terms directly from POEditor via locale:download:missing.

Changes:

Replace locale:missing with locale:download:missing in npm scripts and related docs.
Add/update the POEditor missing-terms downloader workflow and commit paths to use locale/terms/missing/.
Remove the old locale-build-missing.js script and update references/messages accordingly.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`package.json`	Removes `locale:missing` and adds `locale:download:missing` script.
`locale/scripts/poeditor-missing-downloader.js`	Implements missing-terms download from POEditor and writes batched JSON under `locale/terms/missing/`.
`locale/scripts/locale-translate.js`	Updates the user hint to reference `locale:download:missing`.
`locale/scripts/locale-build-missing.js`	Deletes the old local diff–based missing-terms generator.
`locale/README.md`	Collapses missing-terms workflow to the single canonical POEditor-download approach.
`.github/workflows/locale-poeditor-download.yml`	Switches the workflow step to `locale:download:missing` and commits from `locale/terms/missing/`.
`.claude/commands/locale-release.md`	Updates release workflow docs to use `locale:download:missing`.
`.agents/skills/churchcrm/locale-ai-translation.md`	Updates AI translation skill quick start and scripts table to use `locale:download:missing`.

Copilot · 2026-03-06T16:12:05Z

locale/scripts/poeditor-missing-downloader.js

+/**
+ * Fetch the untranslated terms for a locale from POEditor as a JSON object.
+ * Returns null when the locale has no untranslated terms (empty export).
+ */
+async function fetchUntranslatedTerms(poEditorLocale) {
+    const postData = new URLSearchParams({
+        api_token: apiToken,
+        id: PROJECT_ID,
+        language: poEditorLocale,
+        type: 'key_value_json',
+        filters: 'untranslated', // POEditor filter: only export terms without a translation
+    }).toString();
+
+    const response = await makeRequest(POEDITOR_API, postData);
+    const result = JSON.parse(response.data);
+
+    if (result.response.status !== 'success') {
+        throw new Error(result.response.message || 'Unknown POEditor error');
+    }
+
+    const downloadUrl = result.result.url;
+
+    // Download the JSON file from the signed S3 URL
+    return new Promise((resolve, reject) => {
+        https
+            .get(downloadUrl, (res) => {
+                if (res.statusCode < 200 || res.statusCode >= 300) {
+                    let body = '';
+                    res.on('data', (chunk) => {
+                        body += chunk;
+                    });
+                    res.on('end', () =>
+                        reject(
+                            new Error(
+                                `Download failed HTTP ${res.statusCode}: ${body.substring(0, 200)}`,
+                            ),
+                        ),
+                    );
+                    return;
+                }
+
+                let raw = '';
+                res.on('data', (chunk) => {
+                    raw += chunk;
+                });
+                res.on('end', () => {
+                    try {
+                        const parsed = JSON.parse(raw);
+                        resolve(parsed);
+                    } catch (e) {
+                        reject(new Error(`Failed to parse POEditor response: ${e.message}`));
+                    }
+                });


fetchUntranslatedTerms() claims it returns null for an empty export, but the implementation always JSON.parse(raw) and will throw if the download body is empty/whitespace. Consider treating an empty download as “no missing terms” (e.g., return {}) and align the JSDoc + callers accordingly, so fully-translated locales don’t get counted as failures.

Copilot · 2026-03-06T16:12:06Z

locale/scripts/poeditor-missing-downloader.js

+    const entries = Object.entries(missingTerms);
+    const files = [];
+    let batchNumber = 1;
+
+    for (let i = 0; i < entries.length; i += TERMS_PER_FILE) {
+        const batch = Object.fromEntries(entries.slice(i, i + TERMS_PER_FILE));
+        const filename = path.join(localeOutDir, `${poEditorCode}-${batchNumber}.json`);
+        fs.writeFileSync(filename, JSON.stringify(batch, null, 2) + '\n');
+        files.push({ number: batchNumber, filename, count: Object.keys(batch).length });


Batch file contents are built from Object.entries(missingTerms) without any deterministic ordering. If POEditor changes export ordering, batching can churn and create noisy diffs/commits. Sort the entries (e.g., by key) before slicing into batches to keep output stable across runs.

Copilot · 2026-03-06T16:12:06Z

.github/workflows/locale-poeditor-download.yml

          **Missing Terms Reports:**
-          For each incomplete locale, a `poeditor-{locale}.json` file contains all missing/untranslated terms from the master English list. These can be imported into POEditor to help translators complete the translations.
+          For each incomplete locale, batch files under `locale/terms/missing/{locale}/` contain all untranslated terms downloaded directly from POEditor. These can be used with `/locale-translate` or uploaded directly to POEditor.



The missing-terms output folder is keyed by POEditor language code (see locale/terms/missing/{poEditorCode}/ in the downloader and other docs). This PR body text uses {locale}, which can be different (e.g., pt_BR vs pt-br). Update the placeholder to {poEditorCode} to avoid confusion.

Copilot · 2026-03-06T16:12:06Z

.claude/commands/locale-release.md

 ```

-This compares `locale/messages.json` against all installed `src/locale/i18n/*.json` files and writes fresh empty batch files to `locale/terms/missing/{locale}/`.
+This queries POEditor with `filters=untranslated` for each locale and writes fresh empty batch files to `locale/terms/missing/{locale}/`.


The missing-terms directory name is the POEditor code (the --locale <poEditorCode> value), not necessarily the full app locale (e.g., fi_FI). Consider changing locale/terms/missing/{locale}/ to locale/terms/missing/{poEditorCode}/ for accuracy and consistency with the scripts.

Suggested change

This queries POEditor with `filters=untranslated` for each locale and writes fresh empty batch files to `locale/terms/missing/{locale}/`.

This queries POEditor with `filters=untranslated` for each locale and writes fresh empty batch files to `locale/terms/missing/{poEditorCode}/`.

Copilot · 2026-03-06T16:12:06Z

.agents/skills/churchcrm/locale-ai-translation.md

 Every new UI string added to ChurchCRM creates a translation gap in 45+ languages. The AI translation system bridges that gap at release time by:

-1. Reading empty batch files from `locale/terms/missing/{locale}/*.json` (generated by `npm run locale:missing`)
+1. Reading empty batch files from `locale/terms/missing/{locale}/*.json` (generated by `npm run locale:download:missing`)
 2. Translating missing values with Claude Code, applying denomination-aware church vocabulary
 3. Writing translated values back into the same batch files


This path placeholder uses {locale}, but the batch directories are keyed by POEditor language code (what entry.poEditor maps to and what /locale-translate --locale <code> expects). Recommend updating to locale/terms/missing/{poEditorCode}/*.json to match the actual folder layout.

Initial plan

da7d28d

Copilot AI assigned Copilot and DawoudIO Mar 6, 2026

Copilot started work on behalf of DawoudIO March 6, 2026 15:41 View session

Copilot AI changed the title ~~[WIP] Investigate POEditor APIs for downloading missing terms~~ feat: download missing terms per locale directly from POEditor API Mar 6, 2026

Copilot finished work on behalf of DawoudIO March 6, 2026 15:48

Copilot started work on behalf of DawoudIO March 6, 2026 15:48 View session

Copilot AI changed the title ~~feat: download missing terms per locale directly from POEditor API~~ Replace locale:missing with POEditor API-based missing terms download Mar 6, 2026

Copilot finished work on behalf of DawoudIO March 6, 2026 15:53

github-code-quality bot found potential problems Mar 6, 2026

View reviewed changes

locale/scripts/poeditor-missing-downloader.js Fixed Show fixed Hide fixed

Copilot started work on behalf of DawoudIO March 6, 2026 15:55 View session

Copilot AI changed the title ~~Replace locale:missing with POEditor API-based missing terms download~~ Remove locale:missing; standardise on locale:download:missing Mar 6, 2026

Copilot finished work on behalf of DawoudIO March 6, 2026 15:58

Potential fix for pull request finding 'Useless conditional'

22ef4df

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

DawoudIO marked this pull request as ready for review March 6, 2026 16:07

DawoudIO requested a review from a team as a code owner March 6, 2026 16:07

Merge branch 'master' into copilot/check-poeditor-api-missing-terms

4d767e0

DawoudIO requested review from DAcodedBEAT, DawoudIO, MrClever, bigtigerku, Copilot, grayeul and respencer and removed request for a team March 6, 2026 16:08

DawoudIO merged commit 6463cca into master Mar 6, 2026
6 checks passed

DawoudIO deleted the copilot/check-poeditor-api-missing-terms branch March 6, 2026 16:08

Copilot started reviewing on behalf of DawoudIO March 6, 2026 16:08 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove locale:missing; standardise on locale:download:missing#8204

Remove locale:missing; standardise on locale:download:missing#8204
DawoudIO merged 6 commits intomasterfrom
copilot/check-poeditor-api-missing-terms

Copilot AI commented Mar 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	This queries POEditor with `filters=untranslated` for each locale and writes fresh empty batch files to `locale/terms/missing/{locale}/`.
	This queries POEditor with `filters=untranslated` for each locale and writes fresh empty batch files to `locale/terms/missing/{poEditorCode}/`.

Uh oh!

Conversation

Copilot AI commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 6, 2026 •

edited

Loading