-
-
Notifications
You must be signed in to change notification settings - Fork 517
Remove locale:missing; standardise on locale:download:missing #8204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
da7d28d
04fb146
e9a7244
4c0e511
22ef4df
4d767e0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,13 +4,13 @@ Run the full localization pipeline before a release: regenerate missing terms, t | |||||
|
|
||||||
| ## Steps | ||||||
|
|
||||||
| ### Step 1 — Regenerate missing terms | ||||||
| ### Step 1 — Download missing terms from POEditor | ||||||
|
|
||||||
| ```bash | ||||||
| npm run locale:missing | ||||||
| npm run locale:download:missing | ||||||
| ``` | ||||||
|
|
||||||
| This compares `locale/messages.json` against all installed `src/locale/i18n/*.json` files and writes fresh empty batch files to `locale/terms/missing/{locale}/`. | ||||||
| This queries POEditor with `filters=untranslated` for each locale and writes fresh empty batch files to `locale/terms/missing/{locale}/`. | ||||||
|
||||||
| This queries POEditor with `filters=untranslated` for each locale and writes fresh empty batch files to `locale/terms/missing/{locale}/`. | |
| This queries POEditor with `filters=untranslated` for each locale and writes fresh empty batch files to `locale/terms/missing/{poEditorCode}/`. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -224,22 +224,22 @@ jobs: | |
| git config user.name "github-actions[bot]" | ||
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
|
|
||
| - name: Generate missing terms for all locales | ||
| - name: Download missing terms for all locales from POEditor | ||
| if: inputs.operation_mode != 'audit-only' | ||
| run: | | ||
| echo "📋 Generating missing translation terms for all locales..." | ||
| npm run locale:missing | ||
| echo "✅ Missing terms files generated" | ||
| echo "📋 Downloading missing translation terms for all locales from POEditor..." | ||
| npm run locale:download:missing | ||
| echo "✅ Missing terms files downloaded" | ||
|
|
||
| - name: Commit missing terms for POEditor | ||
| if: inputs.operation_mode != 'audit-only' | ||
| run: | | ||
| if [ -d "locale/missing-terms" ] && [ -n "$(find locale/missing-terms -name 'poeditor-*.json' -type f 2>/dev/null)" ]; then | ||
| if [ -d "locale/terms/missing" ] && [ -n "$(find locale/terms/missing -name '*.json' -type f 2>/dev/null)" ]; then | ||
| echo "📝 Committing missing terms files..." | ||
| git add locale/missing-terms/poeditor-*.json | ||
| git add locale/terms/missing/ | ||
| # Check if there are staged changes to commit | ||
| if ! git diff --cached --quiet; then | ||
| git commit -m "📊 Missing translation terms: Updated for all locales from master list" | ||
| git commit -m "locale: update missing translation terms from POEditor" | ||
| echo "✅ Missing terms files committed" | ||
| else | ||
| echo "ℹ️ No new missing terms to commit" | ||
|
|
@@ -278,11 +278,11 @@ jobs: | |
| **What's included:** | ||
| - Updated translation files from POEditor | ||
| - Generated locale JSON files | ||
| - 📊 Missing terms for all locales (in `locale/missing-terms/poeditor-*.json`) | ||
| - 📊 Missing terms for all locales (in `locale/terms/missing/`) | ||
| - Locale audit results | ||
|
|
||
| **Missing Terms Reports:** | ||
| For each incomplete locale, a `poeditor-{locale}.json` file contains all missing/untranslated terms from the master English list. These can be imported into POEditor to help translators complete the translations. | ||
| For each incomplete locale, batch files under `locale/terms/missing/{locale}/` contain all untranslated terms downloaded directly from POEditor. These can be used with `/locale-translate` or uploaded directly to POEditor. | ||
|
|
||
|
Comment on lines
284
to
286
|
||
| This PR was automatically created by the POEditor workflow. | ||
|
|
||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path placeholder uses
{locale}, but the batch directories are keyed by POEditor language code (whatentry.poEditormaps to and what/locale-translate --locale <code>expects). Recommend updating tolocale/terms/missing/{poEditorCode}/*.jsonto match the actual folder layout.