Skip to content

fix: remove duplicate CSS variable '--br-circuit' in themes.ts#737

Merged
Nihal4777 merged 1 commit intoCircuitVerse:mainfrom
Git-HimanshuRathi:fix/duplicate-css-key-themes
Jan 13, 2026
Merged

fix: remove duplicate CSS variable '--br-circuit' in themes.ts#737
Nihal4777 merged 1 commit intoCircuitVerse:mainfrom
Git-HimanshuRathi:fix/duplicate-css-key-themes

Conversation

@Git-HimanshuRathi
Copy link
Contributor

@Git-HimanshuRathi Git-HimanshuRathi commented Jan 8, 2026

Description

This PR removes duplicate --br-circuit CSS variable keys from the theme configuration files, which were causing Vite build warnings during development and production builds.

Problem

The theme files contained duplicate object keys for --br-circuit:

// In Default Theme - line 8 was being overwritten by line 20
'--br-circuit': '#fff',     // Line 8 (duplicate - removed)
// ...
'--br-circuit': '#454545',  // Line 20 (kept)

// In Custom Theme - line 335 was being overwritten by line 347
'--br-circuit': '#ffffff',  // Line 335 (duplicate - removed)
// ...
'--br-circuit': '#454545',  // Line 347 (kept)

This caused the following Vite build warning:

[vite] warning: Duplicate key "--br-circuit" in object literal
  Plugin: vite:esbuild
  File: /cv-frontend-vue/v0/src/simulator/src/themer/themes.ts

Testing

Build completes without duplicate key warnings
Theme functionality remains unchanged (visual verification)

fixes #733

Summary by CodeRabbit

  • Chores
    • Removed the unused CSS variable --br-circuit from Default, Night Sky, and Custom themes.
    • Cleans up theme configurations; no functional or visible changes to the app's appearance expected.

✏️ Tip: You can customize this high-level summary in your review settings.

@netlify
Copy link

netlify bot commented Jan 8, 2026

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 12c23fe
🔍 Latest deploy log https://app.netlify.com/projects/circuitverse/deploys/6965d8b256c1c80008111596
😎 Deploy Preview https://deploy-preview-737--circuitverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 36 (🔴 down 8 from production)
Accessibility: 73 (no change from production)
Best Practices: 92 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026

Walkthrough

The pull request removes duplicate CSS variable declarations for --br-circuit from theme definitions in src/simulator/src/themer/themes.ts. Specifically, the --br-circuit entries were deleted from the Default Theme, Night Sky, and Custom Theme objects to eliminate duplicate key warnings. No other theme properties, exported API signatures, or control flow were changed.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'fix: remove duplicate CSS variable '--br-circuit' in themes.ts' accurately and concisely describes the primary change in the changeset.
Linked Issues check ✅ Passed The PR successfully removes duplicate '--br-circuit' CSS variable entries from theme definitions as required by issue #733, eliminating Vite build warnings without introducing functional changes.
Out of Scope Changes check ✅ Passed All changes in the PR are directly related to removing duplicate '--br-circuit' CSS variables from themes.ts as specified in issue #733; no out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34b0135 and 12c23fe.

📒 Files selected for processing (2)
  • src/simulator/src/themer/themes.ts
  • v1/src/simulator/src/themer/themes.ts
💤 Files with no reviewable changes (2)
  • v1/src/simulator/src/themer/themes.ts
  • src/simulator/src/themer/themes.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Nihal4777
Copy link
Member

@Git-HimanshuRathi Can you please resolve merge conflicts?

@Git-HimanshuRathi Git-HimanshuRathi force-pushed the fix/duplicate-css-key-themes branch from d890ee3 to 34b0135 Compare January 12, 2026 18:35
@Git-HimanshuRathi
Copy link
Contributor Author

@Nihal4777 it's done

Copy link
Member

@Nihal4777 Nihal4777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Git-HimanshuRathi Please apply the changes in v1 as well.

@Git-HimanshuRathi Git-HimanshuRathi force-pushed the fix/duplicate-css-key-themes branch from 34b0135 to 12c23fe Compare January 13, 2026 05:31
Copy link
Member

@Nihal4777 Nihal4777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Git-HimanshuRathi for the improvements. ✨

@Nihal4777 Nihal4777 merged commit 261dfed into CircuitVerse:main Jan 13, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Bug: Duplicate CSS variable key "--br-circuit" in themes.ts causes build warnings

2 participants