Ansible-lint changes to satisfy certificate requirements #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivakasi-cisco
force-pushed
the
lint_changes
branch
from
0a836e5 to
e130e3a
Compare
sivakasi-cisco
force-pushed
the
lint_changes
branch
from
e130e3a to
c79793e
Compare
- Fixed galaxy.yml license format (string to array) - Replaced deprecated include with include_tasks - Removed trailing spaces from all YAML files - Converted truthy values (yes/no to true/false) - Added space after # in comments - Fixed sanity ignore files (removed invalid patterns) - Added missing task names (179 files) - Added FQCN prefix to builtin modules - Fixed free-form set_fact statements - Applied automated YAML formatting fixes
…th proper YAML format
1. Schema Violations
- Replaced deprecated include with ansible.builtin.include_tasks
- Fixed old-style include directives
2. Naming Violations
- Capitalized task names that started with lowercase letters
- Added names to plays and tasks that were missing them
- Fixed naming issues
3. YAML Truthy Violations
- Converted True/False to lowercase true/false
4. Indentation Violations
- Corrected wrong indentation
- Fixed expected vs found indentation mismatches
5. YAML Formatting Issues
- Fixed trailing spaces
- Removed excessive empty lines
- Corrected colon spacing
- Fixed bracket spacing
6. FQCN Violations
- Added ansible.builtin prefix to core module calls
- Applied to include_tasks, set_fact, debug, etc.
7. Module Docstring YAML Errors
- Fixed syntax errors
- Removed excess blank lines in documentation strings
- Corrected YAML formatting in EXAMPLES sections
8. Miscellaneous Fixes
- Fixed no-free-form violations in set_fact calls
- Corrected var-naming pattern
- Fixed jinja2 spacing
sivakasi-cisco
force-pushed
the
lint_changes
branch
from
cc7244f to
02c89c1
Compare
- Fixed playbooks/roles/dcnm_inventory/dcnm_tests.yml (duplicate name key) - Fixed dcnm_bootflash tests (filepath list indentation, set_fact indentation, assert indentation) - Fixed dcnm_image_policy_query.yaml (assert that: block indentation) Reduced load-failure errors from 127 to 122.
- Fixed playbooks/roles/dcnm_inventory/dcnm_tests.yml (duplicate name key, list format) - Fixed dcnm_bootflash tests (3 files: filepath indentation, set_fact indentation, assert blocks) - Fixed dcnm_image_policy_query.yaml (partial: assert that: block indentation) - Restored dcnm_service_node/tasks/main.yaml (45 lines of version detection logic) Reduced load-failure errors from 127 to 122.
sivakasi-cisco
force-pushed
the
lint_changes
branch
from
38e79ff to
b44eeff
Compare
sivakasi-cisco
force-pushed
the
lint_changes
branch
from
b44eeff to
2b7c1b8
Compare
…nment, config structures - reduced errors 122→111
sivakasi-cisco
force-pushed
the
lint_changes
branch
from
8d36191 to
ad04ac7
Compare
sivakasi-cisco
force-pushed
the
lint_changes
branch
3 times, most recently
from
536e9d0 to
e92b035
Compare
sivakasi-cisco
force-pushed
the
lint_changes
branch
from
e92b035 to
1a0760d
Compare
…ert blocks, and duplicate asserts - Fixed GitHub workflow indentation (7 errors) - Fixed 31 files with list item indentation issues - Fixed 72 files with inline 'that:' after 'assert:' - Fixed 39 files with malformed assert blocks - Fixed 39 files with duplicate assert declarations - Fixed 41 files with tasks wrongly nested under assert blocks - Manually fixed 7 files (dcnm_image_upgrade, dcnm_inventory, dcnm_links) - Created 6 automation scripts for systematic fixes - Progress: Fixed ~200+ errors out of 361 total
- Fixed 22 files with inconsistent assert condition list indentation - Created fix_assert_condition_indent.py script - Conditions in assert blocks now have consistent indentation throughout - Fixes 'did not find expected key' errors in dcnm_vrf, dcnm_service_node, and module_integration tests - Progress: dcnm_vrf errors reduced from 6 to 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.