Rename a get_temperature function and add some header comments #82937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
These two functions are(were, prior to this PR) named the same, but do very different things! The former includes heat modifications from sources such as fires or heaters.
This caused one mistake in the past, where these two functions checked entirely different things ( Context #82812 ):
The first function allowed one to 'cheat' by building fires before planting.

Describe the solution
Rename one of the functions and add some explanatory comments.
No functional changes.
Describe alternatives you've considered
Also renaming the untouched get_temperature() to get_local_temperature() or similar, to make it very explicit.
While making this PR I had to get through all existing uses of get_temperature() in the code (33 cases including tests).
There are some which are quite iffy if they should be using local temperature with convective/radiative modifications. But I did not change any in this PR. Maybe it's worth specifically looking at them.
Testing
If it builds it should be good to go.
Additional context