-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[WIP] Skylights and other fragile terrain break when creatures step on them #83684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
added fragile flag to skylight added code in monmove.cpp to make weight/10 in kg apply bash to skylights when moving on them
changed the check falling to be a creature function and added defs
-made movement modes of characters from json affect bash -damage dealt to fragile terrain -relinted jsons -ran astyle
ehughsbaird
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a draft, but you can delete commented out code. It remains in the git history if you need it.
change move mode modifier to a multiplier delete commented code
prone is less generous
Co-authored-by: ehughsbaird <[email protected]>
Co-authored-by: ehughsbaird <[email protected]>
added vehicle icebreaking added ice terrain(doesnt spawn anywhere yet, debug only for now) prevent creatures from breaking fragile tiles when on vehicle
relint terrain-roofs add avoidance of fragile ice and glass floors to npcs and smart monsters
added flags for pit traps and covered traps added ally npc and monster ai for fragile terrain updated covered pits to use physics for boards, works with creature ai
add numeric_bound_reader to prevent negative fix ice description and relint add helper functio/json construction precondition that requires orthogonal terrain or furniture add helper functio/json construction precondition that requires opposing supports below, for bridging gaps made lakes and ocean water channelable added ability to place planks across opposing floors
new covers json for related pit/gap covers new construction group for pit traps
add logic lists for orth_requirement add grass gap cover
|
If moving onto the fragile terrain would cause it to collapse, the player should get a query about wanting to proceed. |
yeah it's on my list, thought it was on the list here, i'll add it |
Summary
Content "Skylights break when stepped on"
Purpose of change
I saw that the skylight JSON had a todo about this
Describe the solution
added function in creature.cpp and creature.h, as well as a terrain tag to mapdata, and the associated tag in skylight.
Now anyone can make breakable terrain by adding the fragile tag to terrain json and using the appropriate bash values.
Describe alternatives you've considered
TBD
Testing
TODO
npcs forced to walk on fragile terrain do so proneNot plannedAdditional context
``