[MoM] Fixing the error that happens when caster selects center position of Force Shove and equivalents #83775
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get_pos == direction_pos on the specific case of force shove and equivalents
github-actions
bot
added
NPC / Factions
Sofistico
changed the title
Sofistico
changed the title
Sofistico
changed the title
github-actions
bot
added
json-styled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on the specific case of force shove and equivalents
Summary
Mods "Fixing force shove center direction position crash"
Purpose of change
I saw that there is a hard crash when the user select the center direction of the knockback effect, i wanted to fix it
Describe the solution
I moved the random selector of position to another if when the target_pos is the same as the direction_pos
Describe alternatives you've considered
Do nothing, give a fail message when the center is selected
Testing
I tested that no crash happened and then i tested that the other directions works