Use fmt instead of string_formatter

[akrieger]

Summary

None

Purpose of change

Windows build got too big for its britches. That motivated me to try to migrate to fmt again after seeing it was a dominant contributor to object file size in the linux build.

Describe the solution

Use fmt::printf so we don't have to change any of our translation strings, ideally.

Describe alternatives you've considered

Idk finding some other way of reducing aggregate binary size. The problem is debug info is huge and ccache is important for our ci time to stay sane.

Testing

Before:

Windows:
$ du -shb objwin/Release/x64/Cataclysm-lib-vcpkg-static/Cataclysm-lib-vcpkg-static-Release-x64.lib
4281132738      objwin/Release/x64/Cataclysm-lib-vcpkg-static/Cataclysm-lib-vcpkg-static-Release-x64.lib
Linux:
akrieger@Bones:~/Cataclysm-DDA$ du -sh cataclysm.a cataclysm-tiles
581M    cataclysm.a
261M    cataclysm-tiles

After:

Windows:
$ du -shb objwin/Release/x64/Cataclysm-lib-vcpkg-static/Cataclysm-lib-vcpkg-static-Release-x64.lib
4091019008      objwin/Release/x64/Cataclysm-lib-vcpkg-static/Cataclysm-lib-vcpkg-static-Release-x64.lib
Linux:
akrieger@Bones:~/Cataclysm-DDA$ du -sh cataclysm.a cataclysm-tiles
426M    cataclysm.a
226M    cataclysm-tiles

Additional context

[akrieger]

Eh saves like 180 megabytes from the archive which I really shouldn't sneeze at.

[akrieger]

Looks green enough but I want to play the game with it more and maybe change a return to a debugmsg to catch more format string issues.

[akrieger]

Bizarre clang-tidy error. I think it's a false positive but I need to ask around.

[akrieger]

Thought about it a bunch, asked around, got enough confirmation it's a false positive that I'll suppress it (including from someone who actually read the implementation of the check). Need to actually put that up though still.

[akrieger]

The base commit is #84562 which can/should land separately.