Skip to content

Make matches working outside of matchboxes/matchbooks #84437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Maleclypse merged 1 commit into from
Jan 7, 2026
Merged

Make matches working outside of matchboxes/matchbooks #84437

Maleclypse merged 1 commit into from
Jan 7, 2026

Conversation

@GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Jan 3, 2026

Summary

None

Purpose of change

Fix #82763
Superseded #84426

Describe the solution

Copypaste code from transform action for qualities_needed field, give matchbook and matchbox the new STRIKING_SURFACE quality, give matches ability to be ignited with STRIKING_SURFACE

Describe alternatives you've considered

Actually just allow to reload matchbooks? maybe it is an overkill?

Testing

Successfully ignited matches outside of matchboxes, successfully didn't ignite it when no striking surface was nearby

image

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 3, 2026
@Maleclypse Maleclypse merged commit 4a811b8 into CleverRaven:master Jan 7, 2026
34 of 41 checks passed
@Maleclypse Maleclypse deleted the matches branch January 7, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Matches become useless

2 participants

@GuardianDll @Maleclypse