Split math_exception_impl constructor in two #84528
Open
+10
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by @akrieger
github-actions
bot
added
[C++]
Merged
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+37
to
+42
| template <typename Arg, typename... Args, | ||
| typename = std::enable_if_t< | ||
| !std::is_same_v<std::decay_t<Arg>, math_exception_impl> | ||
| > | ||
| > | ||
| constexpr explicit math_exception_impl( Args && ...args ) | ||
| constexpr explicit math_exception_impl( Arg &&arg, Args &&... args ) |
Contributor
There was a problem hiding this comment.
[JSON & C++ formatters] reported by reviewdog 🐶
Suggested change
| template <typename Arg, typename... Args, | |
| typename = std::enable_if_t< | |
| !std::is_same_v<std::decay_t<Arg>, math_exception_impl> | |
| > | |
| > | |
| constexpr explicit math_exception_impl( Args && ...args ) | |
| constexpr explicit math_exception_impl( Arg &&arg, Args &&... args ) | |
| template < typename Arg, typename... Args, | |
| typename = std::enable_if_t < | |
| !std::is_same_v<std::decay_t<Arg>, math_exception_impl> | |
| > | |
| > | |
| constexpr explicit math_exception_impl( Arg && arg, Args && ... args ) |
| : exception( string_format( "%s: %s", _severity_str<severity_>(), | ||
| string_format( std::forward<Args>( args )... ) ) ) {} | ||
| string_format( std::forward<Arg>( arg ), | ||
| std::forward<Args>( args )... ) ) ) {} |
Contributor
There was a problem hiding this comment.
[JSON & C++ formatters] reported by reviewdog 🐶
Suggested change
| std::forward<Args>( args )... ) ) ) {} | |
| std::forward<Args>( args )... ) ) ) {} |
github-actions
bot
added
json-styled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @akrieger
Summary
None
Purpose of change
Alternative solution to the clang20 error fixed by #84404
Describe the solution
See the patch
Describe alternatives you've considered
Testing
Built locally under CMake with windows-tiles-sounds-x64-clang-cl profile under VS Insiders 18 and its clang 20
Additional context