Add consistency checks for dangling references

[dumb-kevin]

Summary

Infrastructure "Add consistency checks for dangling references and fix existing ones"

Purpose of change

Various JSON fields that reference other game entities (item IDs, overmap terrains, EOCs, monster types) were not validated during check_consistency(), so typos or stale references after renames would silently break things at runtime. A few such broken references already existed.

Describe the solution

New C++ checks:

• effect_on_condition.cpp - collect EOC string references during load_inline_eoc, validate they all resolve to real IDs in check_consistency(). Error messages include both the mod source and the JSON file path for easy lookup.
• item_factory.cpp - validate repairs_like, source_monster, cooks_like, smoking_result, rot_spawn monster/group
• magic.cpp - warn on summon/spawn_item/summon_monster spells with zero duration and no PERMANENT flag
• profession.cpp - non-hobby professions with starting CBMs must have a trait that cancels NO_CBM_INSTALLATION (e.g. CBM_Interface)
• start_location.cpp - validate om_terrain references exist for all match types (exact, type, subtype, prefix, contains)

JSON fixes (items):

• looks_like pointing at removed power_armor_basic -> combat_exoskeleton_medium (3 files: combat_exoskeleton.json, TEST_DATA/items.json, aftershock exosuit_frame.json)
• looks_like pointing at removed knife_butcher -> knife_huge (cooking.json)
• smoking_result: " " hack on mutflesh -> proper "null" (carnivore.json)

JSON fixes (start locations):

• urban_library changed to PREFIX match to pick up urban_library_* variants
• MA mod: house_two_story_basement -> house_2story_basement (typo in rename), road entries consolidated to TYPE match
• Aftershock: removed sloc_crashed_gunship - the terrain afs_crashed_gunship never existed as an overmap terrain (the gunship is a map extra, mx_gunship; the scenario uses that, not an omt)

JSON fixes (EOC dangling references):

• MindOverMatter: EOC_PORTAL_NULL_AWAKENING -> EOC_MOM_NO_EFFECT (3 places in eoc_selector menus)
• MindOverMatter: EOC_perk_blood_drinking_heal_hp_check was a cross-mod dependency on BombasticPerks. Replaced with mod_interactions/bombastic_perks/ bridge pattern - no-op base EOC when BombasticPerks isn't loaded, delegates to the real one when it is.
• Xedra Evolved: removed stale refs to EOC_REDUCE_VAMPVIRUS1 and EOC_REDUCE_VAMPVIRUS2 from EOC_BLOOD_OF_SAINTS_AGAINST_VAMPIRISM caller. These were merged into EOC_REDUCE_VAMPVIRUS in [ Xedra Evolved ] Vampire cure is broken once again  #78774 but the caller wasn't updated. Also fixed shade_hands -> gracken_shade_hands.
• Innawood: cross-mod EOC references (EOC_on_kill_check_exp etc.) replaced with bridge pattern using mod_interactions/ overrides. Base mod defines no-op stubs, mod_interactions/{bombastic_perks,perk_melee_system,sorcerer}/ files override when those mods are active.
• Magiclysm: added missing EOC_SUMMON_MUSHROOMS definition (was referenced but never defined)

JSON fixes (spells):

• Added PERMANENT_ALL_LEVELS to Magiclysm Alchemist summon spell (zero duration without it)
• Added PERMANENT to MoM electrokinesis spawn_item spell and two Xedra spawn_item spells (Cultivate Goblin Fruit, Seed Bearer)

JSON fixes (professions):

• Added CBM_Interface to MMA cyborg martial artist and MoM Fifth Sun profession (had starting CBMs but no interface trait)

Build script fix:

• get_all_mods.py: use add_mods() instead of raw append() when collecting individual mods. The old code skipped dependency resolution and compatibility checks, so mods could be tested without their prerequisites.

Other:

• flexbuffer_json.h: expose get_root_source_path() on JsonValue (was protected, needed for EOC error context)

New test:

• recipe_cycle_test.cpp - checks for net-positive craft/uncraft exploits. Two cases: with-provenance (player-crafted items, checks uniform component groups) and without-provenance (world-spawned items, checks front()-based disassembly path).

Describe alternatives you've considered

For cross-mod EOC dependencies (Innawood, MoM psychic vampire), the alternative was to keep inline mod_is_loaded conditions, but that means the referenced EOC string fails validation when the other mod isn't loaded. The mod_interactions/ bridge pattern is already used elsewhere in the codebase and avoids the dangling reference entirely.

For looks_like validation -- currently not enforced. There are ~52 unique broken item looks_like values (27 truly missing IDs, 25 cross-type references like items pointing at furniture). Enforcement is feasible but needs a separate cleanup pass, especially for the cross-type cases that are an intentional pattern for appliances.

Testing

• Full build (make TILES=1): clean
• [recipe] test tag: 7060 assertions in 5 test cases, all pass

Additional context

The mod_interactions/ directory loading mechanism (in init.cpp) only loads subdirectory contents when the named mod is also active in the world, so bridge EOCs correctly resolve at load time without hard mod dependencies.

[GuardianDll]

is looks_like needs to be validated? i thought it was used to target id of a texture, ie if we have item foo, which id was renamed to bar, but tileset still used foo, it would correctly pick the texture named "foo"? or something like that? tho it is very questionable pattern, if it is true

The rest LGTM

[github-actions]

Auto-requesting reviews from non-collaborators: @Hymore246

[github-actions]

Auto-requesting reviews from non-collaborators: @Light-Wave

[github-actions]

Auto-requesting reviews from non-collaborators: @ZhilkinSerg

[Maleclypse]

This should be a real start location. Is the issue it shouldn't be a safe location?

[Maleclypse]

went and answered my own question. I didn't make it a terrain because I made it a map update. This makes sense.

[Maleclypse]

oh also apparently I never submitted my review so that's why you never responded to the question.

[dumb-kevin]

So this is resolved, right?