Add the possibility to use the Veros ocean model as the ocean component in ClimaOcean#602
Add the possibility to use the Veros ocean model as the ocean component in ClimaOcean#602simone-silvestri wants to merge 422 commits intomainfrom
Conversation
This reverts commit 4015bf4.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
- Coverage 11.53% 11.07% -0.47%
==========================================
Files 59 61 +2
Lines 3242 3378 +136
==========================================
Hits 374 374
- Misses 2868 3004 +136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nice! the surface temp and salinity don't evolve --- should we plot them or omit them? |
There was a problem hiding this comment.
I suggest the name: veros_ocean_simulation.jl
They evolve very very slowly 😅 . Yeah, let's omit them. |
Co-authored-by: Gregory L. Wagner <wagner.greg@gmail.com>
|
Ok, I think the docs willl pass, so this PR is probably ready. |
docs/src/developers/slab_sea_ice.jl
Outdated
| @@ -0,0 +1,212 @@ | |||
| # # Implementing a Slab Sea Ice Component | |||
There was a problem hiding this comment.
This file slipped in, it was meant for another PR. I will delete it after the docs build so I don't need to wait that the docs build once again
|
Closed in favor of NumericalEarth/NumericalEarth.jl#1 |
4 participants
This is an exploratory PR to use ClimaOcean to force a veros setup.
This exercise is also usefull to make sure that ClimaOcean does not necessarily assume that the ocean model comes from Oceananigans but it is flexible enough to handle different ocean configurations.