Use Veros as another Ocean component in NumericalEarth.jl#1
Use Veros as another Ocean component in NumericalEarth.jl#1simone-silvestri merged 444 commits intomainfrom
Conversation
|
Perfect, CI restarted, now we need to figure out the Issue's issue. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
…arth.jl into ss/adapt-veros
| npx.sqrt( | ||
| (0.5 * (vs.surface_taux[1:-1, 1:-1] + vs.surface_taux[:-2, 1:-1]) / settings.rho_0) ** 2 | ||
| + (0.5 * (vs.surface_tauy[1:-1, 1:-1] + vs.surface_tauy[1:-1, :-2]) / settings.rho_0) ** 2 | ||
| ) ** 1.5, |
There was a problem hiding this comment.
Veros uses TKE as a prognostic variable for which it defines a boundary condition based on the wind stress.
This particular setup we are using has a ocean.set_forcing method we need to overload.
At the moment, the easiest way to do it, to avoid writing a long python setup and to avoid changing the flux computation to introduce extra tracers (which is something I would like to do in another PR) is to overload it from within python with the same method of the setup
https://github.com/team-ocean/veros/blob/f90669d73b2dec8ab8b04d5a7dc574f69510b6e8/veros/setups/global_4deg/global_4deg.py#L227-L274
pruning the extra computation of wind stress and heat flux.
I would like to change this by actually writing the veros setup in the example in python rather than having this fix, and add extra tracers to the flux computation, but I think we can do it in another PR
There was a problem hiding this comment.
It would actually be interesting to write a GPU veros script and run it in the examples
There was a problem hiding this comment.
veros should do this internally. That's what we do with CATKE.
Co-authored-by: Gregory L. Wagner <wagner.greg@gmail.com>
2 participants
Literally just a copy of CliMA/ClimaOcean.jl#602 in this new fork, to see what happens to CI.