Validate location input to FieldBoundaryConditions #4760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchor
approved these changes
Sep 3, 2025
| """ | ||
| function FieldBoundaryConditions(grid::AbstractGrid, loc, indices=(:, :, :); | ||
| function FieldBoundaryConditions(grid::AbstractGrid, loc::Tuple, indices=(:, :, :); | ||
| west = default_auxiliary_bc(grid, Val(:west), loc), |
There was a problem hiding this comment.
We could also just always instantiate the location, so that the constructors would work with both instantiated and non-instantiated locations.
There was a problem hiding this comment.
I think it may be a better/simpler design to require instantiation. I don't think it is inconvenient practically and simplifies using/reading code.
glwagner
commented
Oct 14, 2025
| end | ||
|
|
||
| FieldBoundaryConditions(mrg::MultiRegionGrids, loc, indices; kwargs...) = | ||
| FieldBoundaryConditions(mrg::MultiRegionGrids, loc::Tuple, indices::MultiRegionObject; kwargs...) = |
There was a problem hiding this comment.
@simone-silvestri is this the issue?
There was a problem hiding this comment.
oh, I guess we are missing an import Oceananigans.BoundaryConditions: FieldBoundaryConditions?
There was a problem hiding this comment.
that was definitely missing (otherwise this method doesn't extend anything) but also that didn't fix it hmm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4759