fix: Fix OpAMP url, expose ports & chart maintenance#19
Merged
Conversation
teeohhem
commented
May 29, 2025
| - ReadWriteOnce | ||
| {{- if .Values.global.storageClass }} | ||
| storageClassName: {{ .Values.global.storageClass }} | ||
| {{- end }} |
Contributor
Author
There was a problem hiding this comment.
this prevented chart upgrades
teeohhem
commented
May 29, 2025
| - port: {{ .Values.hyperdx.opampPort }} | ||
| targetPort: {{ .Values.hyperdx.opampPort }} | ||
| name: opamp | ||
| selector: |
Contributor
Author
There was a problem hiding this comment.
expose opamp port in the service
teeohhem
commented
May 29, 2025
| {{- end }} | ||
| - name: OPAMP_SERVER_URL | ||
| value: {{ .Values.otel.opampServerUrl | default (printf "%s-app:%v" (include "hdx-oss.fullname" .) .Values.hyperdx.opampPort ) }} | ||
| value: {{ .Values.otel.opampServerUrl | default (printf "http://%s-app:%v" (include "hdx-oss.fullname" .) .Values.hyperdx.opampPort ) }} |
Contributor
Author
There was a problem hiding this comment.
value was missing http protocol in default value
teeohhem
commented
May 29, 2025
| imageRegistry: "" | ||
| imagePullSecrets: [] | ||
| storageClassName: [] | ||
| storageClassName: "local-path" |
Contributor
Author
There was a problem hiding this comment.
bad default value...should be a string. industry standard is "local-path" as a default
teeohhem
changed the title
wrn14897
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: HDX-1805