-
Notifications
You must be signed in to change notification settings - Fork 40
fix: Fix OpAMP url, expose ports & chart maintenance #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4535744
7f01aba
468d567
023073e
4135b9d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,9 @@ spec: | |
| - port: {{ .Values.hyperdx.appPort }} | ||
| targetPort: {{ .Values.hyperdx.appPort }} | ||
| name: app | ||
| - port: {{ .Values.hyperdx.opampPort }} | ||
| targetPort: {{ .Values.hyperdx.opampPort }} | ||
| name: opamp | ||
| selector: | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. expose opamp port in the service |
||
| {{- include "hdx-oss.selectorLabels" . | nindent 4 }} | ||
| app: {{ include "hdx-oss.fullname" . }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,9 +37,11 @@ spec: | |
| value: "{{ .Values.otel.clickhousePrometheusEndpoint | default (printf "%s-clickhouse:%v" (include "hdx-oss.fullname" .) .Values.clickhouse.prometheus.port ) }}" | ||
| {{- end }} | ||
| - name: OPAMP_SERVER_URL | ||
| value: {{ .Values.otel.opampServerUrl | default (printf "%s-app:%v" (include "hdx-oss.fullname" .) .Values.hyperdx.opampPort ) }} | ||
| value: {{ .Values.otel.opampServerUrl | default (printf "http://%s-app:%v" (include "hdx-oss.fullname" .) .Values.hyperdx.opampPort ) }} | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. value was missing http protocol in default value |
||
| - name: HYPERDX_LOG_LEVEL | ||
| value: {{ .Values.hyperdx.logLevel }} | ||
| - name: HYPERDX_OTEL_EXPORTER_CLICKHOUSE_DATABASE | ||
| value: {{ .Values.hyperdx.clickhouseDatabase | default "default" }} | ||
| - name: HYPERDX_API_KEY | ||
| valueFrom: | ||
| secretKeyRef: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| global: | ||
| imageRegistry: "" | ||
| imagePullSecrets: [] | ||
| storageClassName: [] | ||
| storageClassName: "local-path" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bad default value...should be a string. industry standard is "local-path" as a default |
||
|
|
||
| hyperdx: | ||
| image: "hyperdx/hyperdx:2-beta" | ||
|
|
@@ -14,6 +14,8 @@ hyperdx: | |
| usageStatsEnabled: true | ||
| # Endpoint to send hyperdx logs/traces/metrics to.Defaults to the chart's otel collector endpoint. | ||
| otelExporterEndpoint: http://{{ include "hdx-oss.fullname" . }}-otel-collector:{{ .Values.otel.httpPort }} | ||
| # Clickhouse database to send logs/traces/metrics to. Defaults to "default" | ||
| clickhouseDatabase: "default" | ||
| annotations: {} | ||
| # myAnnotation: "myValue" | ||
| labels: {} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this prevented chart upgrades