Skip to content

migration: move clickhouseDatabase setting from hyperdx to otel values #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wrn14897 merged 1 commit into from
Jun 3, 2025
Merged

migration: move clickhouseDatabase setting from hyperdx to otel values #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/hdx-oss-v2/templates/otel-collector-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ spec:
- name: HYPERDX_LOG_LEVEL
value: {{ .Values.hyperdx.logLevel }}
- name: HYPERDX_OTEL_EXPORTER_CLICKHOUSE_DATABASE
value: {{ .Values.hyperdx.clickhouseDatabase | default "default" }}
value: {{ .Values.otel.clickhouseDatabase | default "default" }}
- name: HYPERDX_API_KEY
valueFrom:
secretKeyRef:
Expand Down
2 changes: 1 addition & 1 deletion charts/hdx-oss-v2/tests/otel-collector_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,9 +338,9 @@ tests:
otel:
enabled: true
image: hyperdx/hyperdx-otel-collector:2-beta
clickhouseDatabase: "custom_db"
hyperdx:
logLevel: info
clickhouseDatabase: "custom_db"
clickhouse:
config:
users:
Expand Down
4 changes: 2 additions & 2 deletions charts/hdx-oss-v2/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ hyperdx:
usageStatsEnabled: true
# Endpoint to send hyperdx logs/traces/metrics to.Defaults to the chart's otel collector endpoint.
otelExporterEndpoint: http://{{ include "hdx-oss.fullname" . }}-otel-collector:{{ .Values.otel.httpPort }}
# Clickhouse database to send logs/traces/metrics to. Defaults to "default"
clickhouseDatabase: "default"
annotations: {}
# myAnnotation: "myValue"
labels: {}
Expand Down Expand Up @@ -204,6 +202,8 @@ otel:
# Leave empty if prometheus is disabled.
# Example: clickhousePrometheusEndpoint: "http://custom-clickhouse-service:9363"
clickhousePrometheusEndpoint:
# Clickhouse database to send logs/traces/metrics to. Defaults to "default"
clickhouseDatabase: "default"

persistence:
mongodb:
Expand Down