Skip to content

Conversation

@JoyfulShush
Copy link
Contributor

No description provided.

@Bittah Bittah force-pushed the master branch 2 times, most recently from cefcea1 to 723d557 Compare September 19, 2025 11:33
Copy link
Member

@Rampastring Rampastring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed until NamedColors.cs.

It's mostly good work but there's some things to fix. Several things have duplicate IDs, which means translation strings will override one another.

Some IDs could be clearer in the context, I've left feedback on them.

In MapLoader.cs the Translate(MapLoader.... pattern is repeated so often that I'd make a shortcut method in MapLoader, called Translate that automatically adds MapLoader. to the beginning of the ID. For example, CursorAction uses the same pattern in CursorAction.Translate. Then you could remove the currently manually specified MapLoader. part of all IDs in MapLoader.cs.

Translating NamedColors might not work properly right now, because the NamedColors array is public static, it might be initialized before the user has left the main menu (and selected their language). It might be necessary to add a static Initialize method to the NamedColors class that will initialize the array when called.

Copy link
Member

@Rampastring Rampastring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the rest of the files. It's mostly good, but here's 19 more things to improve or fix.

@Rampastring Rampastring merged commit 05dbda2 into CnCNet:master Oct 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants