-
Notifications
You must be signed in to change notification settings - Fork 37
Add translations for all remaining strings in WAE #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Kuronoseihai <[email protected]>
cefcea1 to
723d557
Compare
Rampastring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed until NamedColors.cs.
It's mostly good work but there's some things to fix. Several things have duplicate IDs, which means translation strings will override one another.
Some IDs could be clearer in the context, I've left feedback on them.
In MapLoader.cs the Translate(MapLoader.... pattern is repeated so often that I'd make a shortcut method in MapLoader, called Translate that automatically adds MapLoader. to the beginning of the ID. For example, CursorAction uses the same pattern in CursorAction.Translate. Then you could remove the currently manually specified MapLoader. part of all IDs in MapLoader.cs.
Translating NamedColors might not work properly right now, because the NamedColors array is public static, it might be initialized before the user has left the main menu (and selected their language). It might be necessary to add a static Initialize method to the NamedColors class that will initialize the array when called.
src/TSMapEditor/Config/Scripts/Replace Autumn Trees With Summer Trees.cs
Outdated
Show resolved
Hide resolved
src/TSMapEditor/Config/Scripts/Replace Autumn Trees With Summer Trees.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Rami Pasanen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the rest of the files. It's mostly good, but here's 19 more things to improve or fix.
No description provided.