Select and scroll to locked game when joining#913
Select and scroll to locked game when joining#91311EJDE11 wants to merge 2 commits intoCnCNet:developfrom
Conversation
|
Nightly build for this pull request:
|
|
What if the player wants to join a room by double clicking it? Will the scroll thing happen too and will it causes some trouble? |
There was a problem hiding this comment.
Pull request overview
Updates the multiplayer lobby join flow so that attempting to join a locked game provides more context (game name) and (for player-list joins) highlights the associated game in the game list.
Changes:
- Updated “game locked” messaging to include the room name.
- Adjusted CnCNet “invite-only/locked on join” handling to mark the game locked and refresh the list.
- Added logic to select + scroll to the user’s game in the CnCNet lobby when joining via player list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| DXMainClient/DXGUI/Multiplayer/LANLobby.cs | Includes the locked game’s name in the LAN lobby lock message. |
| DXMainClient/DXGUI/Multiplayer/CnCNet/CnCNetLobby.cs | Includes the locked game’s name in join errors, adjusts locked-on-join messaging, and selects/scrolls to the target game when joining a user. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No, not an issue. This only applies when joining trying to join a player (like right click on a player and choose Join). |
| } | ||
|
|
||
| ClearGameJoinAttempt((Channel)sender); | ||
| ClearGameJoinAttempt((Channel)sender); |
3 participants
Currently when choosing "Join" from the player list context menu, and the game is locked, you get "The selected game is locked.". With this PR, it will now provide the game name, and select and scroll to the game.