Add standby option #17

CoMPaTech · 2025-07-13T09:03:52Z

Summary by CodeRabbit

Bug Fixes
- Improved handling of fan speed set to zero, now correctly sending either low speed or standby command based on configuration.
Documentation
- Added a clarifying comment to the configuration option for better understanding of its usage.

coderabbitai · 2025-07-13T09:03:58Z

Walkthrough

The changes update the fan speed control logic in the CC1101 component by introducing a conditional branch for handling speed 0, based on the map_off_to_zero_ configuration. Additionally, the documentation is updated to clarify the intended use of this configuration option in the YAML example.

Changes

File(s)	Change Summary
components/cc1101/fan.cpp	Modified `set_fan_speed` to send either `IthoLow` or `IthoStandby` for speed 0, based on configuration; extended `ITHOcheck` to handle `IthoStandby` command.
components/cc1101/README.md	Added a clarifying comment to the `map_off_to_zero` YAML configuration example.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FanComponent
    participant RFModule

    User->>FanComponent: set_fan_speed(0)
    alt map_off_to_zero_ is True
        FanComponent->>RFModule: send(IthoLow)
    else map_off_to_zero_ is False
        FanComponent->>RFModule: send(IthoStandby)
    end

Poem

A bunny tweaks the fan with care,
Now speed zero’s handled fair—
Off or low, you get to choose,
With a comment to diffuse
Confusion in the YAML line.
Hopping forward, code refined!
🐇💨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 36f7d26 and 9674a5b.

📒 Files selected for processing (1)

components/cc1101/fan.cpp (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

components/cc1101/fan.cpp

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch standby

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

components/cc1101/fan.cpp (1)
149-150: Improve code formatting and consider adding IthoStandby receive handling.

The conditional logic correctly implements the standby functionality, but there are two improvements to consider:

Formatting: The else clause should be properly formatted for consistency.

Missing receive handling: The ITHOcheck() method doesn't handle IthoStandby commands in its switch statement, which could cause issues if other remotes send standby commands.

Formatting fix:
      case 0:
-        if ( this->map_off_to_zero_) { rf.sendCommand(IthoLow); }
-          else { rf.sendCommand(IthoStandby); }
+        if (this->map_off_to_zero_) {
+          rf.sendCommand(IthoLow);
+        } else {
+          rf.sendCommand(IthoStandby);
+        }
        break;
Add IthoStandby handling in ITHOcheck method:
      case IthoLow:
        ESP_LOGD("c1101_fan", "1 / Low (or 0 / Off)");
        // ... existing logic ...
        break;
+     case IthoStandby:
+       ESP_LOGD("c1101_fan", "0 / Standby");
+       if (timer_active_) {
+         reset_timer_.detach();
+         ESP_LOGD("cc1101_fan", "Timer was active and has been canceled received remote sending standby");
+       }
+       this->LastSpeed = this->Speed;
+       this->Speed = 0;
+       break;
      case IthoMedium:

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 156a132 and 36f7d26.

📒 Files selected for processing (2)

components/cc1101/README.md (1 hunks)
components/cc1101/fan.cpp (1 hunks)

🔇 Additional comments (1)

components/cc1101/README.md (1)

89-89: Excellent documentation improvement.

The clarifying comment helps users understand when to use True vs False for the map_off_to_zero configuration, which directly corresponds to the new standby functionality implementation.

CoMPaTech · 2025-10-05T16:45:16Z

Note 2 self - waiting on user to test this

Add standby option

36f7d26

CoMPaTech self-assigned this Jul 13, 2025

CoMPaTech added the enhancement New feature or request label Jul 13, 2025

coderabbitai bot reviewed Jul 13, 2025

View reviewed changes

coderabbitai bot approved these changes Jul 13, 2025

View reviewed changes

CRAI nitpicks

9674a5b

CoMPaTech mentioned this pull request Jul 13, 2025

sendfanhigh/medium/low and speed_count display #16

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add standby option #17

Add standby option #17

Uh oh!

CoMPaTech commented Jul 13, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 13, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

CoMPaTech commented Oct 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add standby option #17

Are you sure you want to change the base?

Add standby option #17

Uh oh!

Conversation

CoMPaTech commented Jul 13, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

CoMPaTech commented Oct 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CoMPaTech commented Jul 13, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)