Skip to content

Conversation

GuillaumeLagrange
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange commented Jun 25, 2025

fixes #12

Disclaimer: Windows is not yet properly tested nor supported, this PR is just to prevent build errors for applications that use codpeed's google benchmark but still need to be able to build for windows target.

Copy link

codspeed-hq bot commented Jun 25, 2025

CodSpeed Instrumentation Performance Report

Merging #15 will not alter performance

Comparing cod-1033-doesnt-build-on-windows (7da6671) with main (d68b802)

Summary

✅ 42 untouched benchmarks

Copy link

codspeed-hq bot commented Jun 25, 2025

CodSpeed WallTime Performance Report

Merging #15 will degrade performances by 20%

Comparing cod-1033-doesnt-build-on-windows (7da6671) with main (d68b802)

Summary

⚡ 1 improvements
❌ 8 regressions
✅ 33 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
DoubleTest[MyTemplatedFixture, double] < 1 ns < 1 ns +25%
FooTest[MyFixture] < 1 ns < 1 ns -20%
IntTest[MyTemplatedFixture, int] < 1 ns < 1 ns -20%
TestA[MyTemplate1, int] < 1 ns < 1 ns -16.67%
BM_Capture[int_string_test] < 1 ns < 1 ns -16.67%
BM_Capture[int_test] < 1 ns < 1 ns -20%
BM_rand_vector < 1 ns < 1 ns -16.67%
BM_Template1_Capture[int_string_test] < 1 ns < 1 ns -20%
BM_Template1_Capture[two_type_test, int, double] < 1 ns < 1 ns -16.67%

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1033-doesnt-build-on-windows branch from eec6bc2 to dc5d317 Compare June 25, 2025 16:29
@anonrig
Copy link

anonrig commented Jun 25, 2025

Can you add windows to your GitHub workflow?

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1033-doesnt-build-on-windows branch 12 times, most recently from bdb7561 to 0fe9e59 Compare June 25, 2025 20:24
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1033-doesnt-build-on-windows branch from 0fe9e59 to 5fa0322 Compare June 25, 2025 20:28
@GuillaumeLagrange GuillaumeLagrange changed the title fix(core): use proper type for pid on windows Fix windows build and add windows CI Jun 26, 2025
@adriencaccia adriencaccia requested a review from art049 June 26, 2025 09:12
Copy link
Member

@not-matthias not-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only some minor style/code remarks

@anonrig
Copy link

anonrig commented Jun 26, 2025

Can we get this merged?

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1033-doesnt-build-on-windows branch 2 times, most recently from e8737ee to 74af7a7 Compare June 27, 2025 09:32
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1033-doesnt-build-on-windows branch 5 times, most recently from 18278fe to 9a3151f Compare June 27, 2025 09:57
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1033-doesnt-build-on-windows branch from 75817e4 to 76e07a5 Compare June 27, 2025 10:10
This way we can get early warnings in our CI without disrupting
downstream users by adding -Wall -Werror etc if they do not wish to do
so.
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1033-doesnt-build-on-windows branch from 76e07a5 to 7da6671 Compare June 27, 2025 10:13
@GuillaumeLagrange GuillaumeLagrange merged commit 7da6671 into main Jun 27, 2025
12 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-1033-doesnt-build-on-windows branch June 27, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doesn't build on Windows

4 participants