-
Notifications
You must be signed in to change notification settings - Fork 2
Fix windows build and add windows CI #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Instrumentation Performance ReportMerging #15 will not alter performanceComparing Summary
|
CodSpeed WallTime Performance ReportMerging #15 will degrade performances by 20%Comparing Summary
Benchmarks breakdown
|
eec6bc2
to
dc5d317
Compare
Can you add windows to your GitHub workflow? |
bdb7561
to
0fe9e59
Compare
0fe9e59
to
5fa0322
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only some minor style/code remarks
Can we get this merged? |
e8737ee
to
74af7a7
Compare
18278fe
to
9a3151f
Compare
75817e4
to
76e07a5
Compare
This way we can get early warnings in our CI without disrupting downstream users by adding -Wall -Werror etc if they do not wish to do so.
76e07a5
to
7da6671
Compare
fixes #12
Disclaimer: Windows is not yet properly tested nor supported, this PR is just to prevent build errors for applications that use codpeed's google benchmark but still need to be able to build for windows target.