fix: always print memory mapping logs #166
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-matthias
force-pushed
the
cod-1742-codspeed-go-flamegraph-not-shown-for-many-benchmarks
branch
from
15b5a9b to
c84a798
Compare
Copilot finished reviewing on behalf of
not-matthias
November 25, 2025 17:26
There was a problem hiding this comment.
Pull request overview
This PR removes a redundant conditional check for debug mode when logging memory mappings, ensuring these valuable logs are always available for debugging unsymbolicated addresses.
Key Changes:
- Removed
is_codspeed_debug_enabled()check around memory mapping debug logs since thedebug!macro already respects log level configuration - Updated test snapshots to use Git LFS storage for large binary content
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/run/runner/wall_time/perf/mod.rs | Removed redundant debug mode check around memory mapping logs in process_memory_mappings function |
| src/run/runner/wall_time/perf/snapshots/*.snap | Converted large snapshot files to use Git LFS storage format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered this during the investigation of COD-1742 that we don't have the memory mapping logs inside
runner.log. This information is very valuable to know where unsymbolicated addresses are located in memory.It doesn't make much sense to check for debug mode here, because we won't show the debug logs if we're not in DEBUG mode.