Skip to content

Birmingham | 25-ITP-Sept | Khor Biel | Sprint 2 | feature/book-library #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wankoak wants to merge 8 commits into from
Closed

Birmingham | 25-ITP-Sept | Khor Biel | Sprint 2 | feature/book-library #337

wankoak wants to merge 8 commits into from

Conversation

@wankoak
Copy link

@wankoak wankoak commented Nov 29, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Here’s a shorter, clean PR description:

Fixed Library App Functionality

What’s Fixed

  • Books now render correctly on page load.
  • Add-book form works and no longer throws errors.
  • Author field is correctly used instead of title.
  • Read/unread toggle works properly.
  • Delete button functions for every row.
  • Cleaned up broken JavaScript syntax and incorrect variable names.

Other Improvements

  • Repaired invalid HTML input types.
  • Removed placeholder table row.
  • Minor CSS cleanup for spacing.

No question

@wankoak wankoak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 29, 2025
cjyuan
cjyuan reviewed Nov 30, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 30, 2025
@wankoak wankoak added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 1, 2025
cjyuan
cjyuan reviewed Dec 3, 2025
View reviewed changes
debugging/book-library/index.html
Copy link
Contributor

@cjyuan cjyuan Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are errors in the HTML code.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 3, 2025
@wankoak wankoak added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 3, 2025
@wankoak wankoak added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 3, 2025
cjyuan
cjyuan reviewed Dec 3, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great. Would be even better if you could also respond to the comments.

debugging/book-library/script.js

// pages should be a positive integer (prevent "weird" page counts)
const pNum = Number(pRaw);
if (!Number.isFinite(pNum) || pNum <= 0 || !Number.isInteger(pNum)) {
Copy link
Contributor

@cjyuan cjyuan Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is solid. The first condition is optional because of this check: !Number.isInteger(pNum).

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 3, 2025
@wankoak
Copy link
Author

wankoak commented Dec 3, 2025

@cjyuan I did respond to the comments and marked them resolved

@cjyuan
Copy link
Contributor

cjyuan commented Dec 3, 2025

I was referring to written responses.

@wankoak wankoak mentioned this pull request Dec 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wankoak @cjyuan @illicitonion