generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 162
Birmingham | 25-ITP-Sept | Khor Biel | Sprint 2 | feature/book-library #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c3b333a
Fixed input types, clean markup, and ensure table renders properly
wankoak 9b4e471
Resolved multiple logic and syntax errors, repair delete/read buttons…
wankoak d310d24
Cleaned up CSS formatting, simplified layout rules, and adjusted spac…
wankoak 5d22b66
made small changes
wankoak 5ac4fe4
Fixed html
wankoak eaf251d
Updated js
wankoak b0d48ba
Merge branch 'main' into feature/book-library
wankoak 5bc0cb7
Fix HTML errors and update JS per reviewer feedback
wankoak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,103 +1,112 @@ | ||
| let myLibrary = []; | ||
|
|
||
| // DOM refs | ||
| const titleInput = document.getElementById("title"); | ||
| const authorInput = document.getElementById("author"); | ||
| const pagesInput = document.getElementById("pages"); | ||
| const checkInput = document.getElementById("check"); | ||
| const submitBtn = document.getElementById("submitBtn"); | ||
| const table = document.getElementById("display"); | ||
|
|
||
| window.addEventListener("load", function (e) { | ||
| populateStorage(); | ||
| render(); | ||
| }); | ||
|
|
||
| function populateStorage() { | ||
| if (myLibrary.length == 0) { | ||
| let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); | ||
| let book2 = new Book( | ||
| const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true); | ||
| const book2 = new Book( | ||
| "The Old Man and the Sea", | ||
| "Ernest Hemingway", | ||
| "127", | ||
| 127, | ||
| true | ||
| ); | ||
| myLibrary.push(book1); | ||
| myLibrary.push(book2); | ||
| render(); | ||
| myLibrary.push(book1, book2); | ||
| } | ||
| } | ||
|
|
||
| const title = document.getElementById("title"); | ||
| const author = document.getElementById("author"); | ||
| const pages = document.getElementById("pages"); | ||
| const check = document.getElementById("check"); | ||
|
|
||
| //check the right input from forms and if its ok -> add the new book (object in array) | ||
| //via Book function and start render function | ||
| function submit() { | ||
| if ( | ||
| title.value == null || | ||
| title.value == "" || | ||
| pages.value == null || | ||
| pages.value == "" | ||
| ) { | ||
| // wire submit button | ||
| submitBtn.addEventListener("click", addBook); | ||
|
|
||
| // validate and add book to library | ||
| function addBook() { | ||
| // trim to avoid spaces-only input | ||
| const t = titleInput.value.trim(); | ||
| const a = authorInput.value.trim(); | ||
| const pRaw = pagesInput.value.trim(); | ||
|
|
||
| if (!t || !a || !pRaw) { | ||
| alert("Please fill all fields!"); | ||
| return false; | ||
| } else { | ||
| let book = new Book(title.value, title.value, pages.value, check.checked); | ||
| library.push(book); | ||
| render(); | ||
| return; | ||
| } | ||
|
|
||
| // pages should be a positive integer (prevent "weird" page counts) | ||
| const pNum = Number(pRaw); | ||
| if (!Number.isFinite(pNum) || pNum <= 0 || !Number.isInteger(pNum)) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is solid. The first condition is optional because of this check: |
||
| alert("Please enter a valid positive whole number of pages."); | ||
| return; | ||
| } | ||
|
|
||
| const book = new Book(t, a, pNum, checkInput.checked); | ||
| myLibrary.push(book); | ||
|
|
||
| // clear inputs and close the collapse | ||
| titleInput.value = ""; | ||
| authorInput.value = ""; | ||
| pagesInput.value = ""; | ||
| checkInput.checked = false; | ||
|
|
||
| render(); | ||
| } | ||
|
|
||
| function Book(title, author, pages, check) { | ||
| // Book constructor | ||
| function Book(title, author, pages, read) { | ||
| this.title = title; | ||
| this.author = author; | ||
| this.pages = pages; | ||
| this.check = check; | ||
| this.read = !!read; | ||
| } | ||
|
|
||
| // render table rows from myLibrary | ||
| function render() { | ||
| let table = document.getElementById("display"); | ||
| let rowsNumber = table.rows.length; | ||
| //delete old table | ||
| for (let n = rowsNumber - 1; n > 0; n-- { | ||
| table.deleteRow(n); | ||
| } | ||
| //insert updated row and cells | ||
| let length = myLibrary.length; | ||
| for (let i = 0; i < length; i++) { | ||
| let row = table.insertRow(1); | ||
| let titleCell = row.insertCell(0); | ||
| let authorCell = row.insertCell(1); | ||
| let pagesCell = row.insertCell(2); | ||
| let wasReadCell = row.insertCell(3); | ||
| let deleteCell = row.insertCell(4); | ||
| titleCell.innerHTML = myLibrary[i].title; | ||
| authorCell.innerHTML = myLibrary[i].author; | ||
| pagesCell.innerHTML = myLibrary[i].pages; | ||
|
|
||
| //add and wait for action for read/unread button | ||
| let changeBut = document.createElement("button"); | ||
| changeBut.id = i; | ||
| changeBut.className = "btn btn-success"; | ||
| wasReadCell.appendChild(changeBut); | ||
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
|
|
||
| changeBut.addEventListener("click", function () { | ||
| myLibrary[i].check = !myLibrary[i].check; | ||
| const tbody = table.querySelector("tbody"); | ||
| tbody.innerHTML = ""; | ||
|
|
||
| for (let i = 0; i < myLibrary.length; i++) { | ||
| const book = myLibrary[i]; | ||
| const row = tbody.insertRow(); | ||
|
|
||
| const titleCell = row.insertCell(0); | ||
| const authorCell = row.insertCell(1); | ||
| const pagesCell = row.insertCell(2); | ||
| const wasReadCell = row.insertCell(3); | ||
| const deleteCell = row.insertCell(4); | ||
|
|
||
| titleCell.textContent = book.title; | ||
| authorCell.textContent = book.author; | ||
| pagesCell.textContent = book.pages; | ||
|
|
||
| // Read toggle button | ||
| const changeBut = document.createElement("button"); | ||
| changeBut.className = "btn btn-sm btn-outline-success"; | ||
| changeBut.textContent = book.read ? "Yes" : "No"; | ||
| changeBut.addEventListener("click", function() { | ||
| myLibrary[i].read = !myLibrary[i].read; | ||
| render(); | ||
| }); | ||
| wasReadCell.appendChild(changeBut); | ||
|
|
||
| //add delete button to every row and render again | ||
| let delButton = document.createElement("button"); | ||
| delBut.id = i + 5; | ||
| deleteCell.appendChild(delBut); | ||
| delBut.className = "btn btn-warning"; | ||
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); | ||
| myLibrary.splice(i, 1); | ||
| render(); | ||
| // Delete button | ||
| const delBut = document.createElement("button"); | ||
| delBut.className = "btn btn-sm btn-warning"; | ||
| delBut.textContent = "Delete"; | ||
| delBut.addEventListener("click", function() { | ||
| if (confirm(`Delete "${myLibrary[i].title}"?`)) { | ||
| myLibrary.splice(i, 1); | ||
| render(); | ||
| } | ||
| }); | ||
| deleteCell.appendChild(delBut); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| .form-group { | ||
| width: 400px; | ||
| height: 300px; | ||
| align-self: left; | ||
| padding-left: 20px; | ||
| } | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are errors in the HTML code.